* Re: [NETFILTER]: Use correct type for "ports" module parameter
[not found] <200509140100.j8E10NLw009915@hera.kernel.org>
@ 2005-09-15 17:57 ` Benjamin LaHaise
0 siblings, 0 replies; only message in thread
From: Benjamin LaHaise @ 2005-09-15 17:57 UTC (permalink / raw)
To: davem; +Cc: Linux Kernel Mailing List
On Tue, Sep 13, 2005 at 06:00:23PM -0700, Linux Kernel Mailing List wrote:
> --- a/net/ipv4/netfilter/ip_conntrack_ftp.c
> +++ b/net/ipv4/netfilter/ip_conntrack_ftp.c
> @@ -29,9 +29,9 @@ static char *ftp_buffer;
> static DEFINE_SPINLOCK(ip_ftp_lock);
>
> #define MAX_PORTS 8
> -static int ports[MAX_PORTS];
> +static short ports[MAX_PORTS];
> static int ports_c;
> -module_param_array(ports, int, &ports_c, 0400);
> +module_param_array(ports, short, &ports_c, 0400);
Shouldn't this be unsigned short? As near as I can tell the negative sign
extension will result in the same problem this patch was trying to fix as
the code does 'sprintf(tmpname, "ftp-%d", ports[i]);'...
-ben
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2005-09-15 17:58 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <200509140100.j8E10NLw009915@hera.kernel.org>
2005-09-15 17:57 ` [NETFILTER]: Use correct type for "ports" module parameter Benjamin LaHaise
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox