* [PATCH] RT: unwritten_done_lock to DEFINE_SPINLOCK
@ 2005-09-27 18:32 Daniel Walker
2005-09-27 22:28 ` Thomas Gleixner
2005-09-28 9:34 ` Ingo Molnar
0 siblings, 2 replies; 4+ messages in thread
From: Daniel Walker @ 2005-09-27 18:32 UTC (permalink / raw)
To: mingo; +Cc: linux-kernel
Convert unwritten_done_lock xfs lock to the new syntax.
Signed-Off-By: Daniel Walker <dwalker@mvista.com>
Index: linux-2.6.13/fs/xfs/linux-2.6/xfs_aops.c
===================================================================
--- linux-2.6.13.orig/fs/xfs/linux-2.6/xfs_aops.c
+++ linux-2.6.13/fs/xfs/linux-2.6/xfs_aops.c
@@ -192,7 +192,7 @@ linvfs_unwritten_done(
int uptodate)
{
xfs_ioend_t *ioend = bh->b_private;
- static spinlock_t unwritten_done_lock = SPIN_LOCK_UNLOCKED;
+ static DECLARE_SPINLOCK(unwritten_done_lock);
unsigned long flags;
ASSERT(buffer_unwritten(bh));
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] RT: unwritten_done_lock to DEFINE_SPINLOCK
2005-09-27 18:32 [PATCH] RT: unwritten_done_lock to DEFINE_SPINLOCK Daniel Walker
@ 2005-09-27 22:28 ` Thomas Gleixner
2005-09-28 9:34 ` Ingo Molnar
1 sibling, 0 replies; 4+ messages in thread
From: Thomas Gleixner @ 2005-09-27 22:28 UTC (permalink / raw)
To: dwalker; +Cc: mingo, linux-kernel
On Tue, 2005-09-27 at 11:32 -0700, Daniel Walker wrote:
> Convert unwritten_done_lock xfs lock to the new syntax.
>
> Signed-Off-By: Daniel Walker <dwalker@mvista.com>
>
> Index: linux-2.6.13/fs/xfs/linux-2.6/xfs_aops.c
> ===================================================================
> --- linux-2.6.13.orig/fs/xfs/linux-2.6/xfs_aops.c
> +++ linux-2.6.13/fs/xfs/linux-2.6/xfs_aops.c
> @@ -192,7 +192,7 @@ linvfs_unwritten_done(
> int uptodate)
> {
> xfs_ioend_t *ioend = bh->b_private;
> - static spinlock_t unwritten_done_lock = SPIN_LOCK_UNLOCKED;
> + static DECLARE_SPINLOCK(unwritten_done_lock);
> unsigned long flags;
Did you actually compile this ?
tglx
--- linux-2.6.13.orig/fs/xfs/linux-2.6/xfs_aops.c
+++ linux-2.6.13/fs/xfs/linux-2.6/xfs_aops.c
@@ -192,7 +192,7 @@ linvfs_unwritten_done(
int uptodate)
{
xfs_ioend_t *ioend = bh->b_private;
- static spinlock_t unwritten_done_lock = SPIN_LOCK_UNLOCKED;
+ static DEFINE_SPINLOCK(unwritten_done_lock);
unsigned long flags;
ASSERT(buffer_unwritten(bh));
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] RT: unwritten_done_lock to DEFINE_SPINLOCK
2005-09-27 18:32 [PATCH] RT: unwritten_done_lock to DEFINE_SPINLOCK Daniel Walker
2005-09-27 22:28 ` Thomas Gleixner
@ 2005-09-28 9:34 ` Ingo Molnar
2005-09-28 15:04 ` Daniel Walker
1 sibling, 1 reply; 4+ messages in thread
From: Ingo Molnar @ 2005-09-28 9:34 UTC (permalink / raw)
To: Daniel Walker; +Cc: linux-kernel
* Daniel Walker <dwalker@mvista.com> wrote:
> Convert unwritten_done_lock xfs lock to the new syntax.
>
> Signed-Off-By: Daniel Walker <dwalker@mvista.com>
>
> Index: linux-2.6.13/fs/xfs/linux-2.6/xfs_aops.c
> ===================================================================
> --- linux-2.6.13.orig/fs/xfs/linux-2.6/xfs_aops.c
> +++ linux-2.6.13/fs/xfs/linux-2.6/xfs_aops.c
> @@ -192,7 +192,7 @@ linvfs_unwritten_done(
> int uptodate)
> {
> xfs_ioend_t *ioend = bh->b_private;
> - static spinlock_t unwritten_done_lock = SPIN_LOCK_UNLOCKED;
> + static DECLARE_SPINLOCK(unwritten_done_lock);
applied, with the additional detail that it's DEFINE, not DECLARE.
Ingo
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] RT: unwritten_done_lock to DEFINE_SPINLOCK
2005-09-28 9:34 ` Ingo Molnar
@ 2005-09-28 15:04 ` Daniel Walker
0 siblings, 0 replies; 4+ messages in thread
From: Daniel Walker @ 2005-09-28 15:04 UTC (permalink / raw)
To: Ingo Molnar; +Cc: linux-kernel
On Wed, 2005-09-28 at 11:34 +0200, Ingo Molnar wrote:
> * Daniel Walker <dwalker@mvista.com> wrote:
>
> > Convert unwritten_done_lock xfs lock to the new syntax.
> >
> > Signed-Off-By: Daniel Walker <dwalker@mvista.com>
> >
> > Index: linux-2.6.13/fs/xfs/linux-2.6/xfs_aops.c
> > ===================================================================
> > --- linux-2.6.13.orig/fs/xfs/linux-2.6/xfs_aops.c
> > +++ linux-2.6.13/fs/xfs/linux-2.6/xfs_aops.c
> > @@ -192,7 +192,7 @@ linvfs_unwritten_done(
> > int uptodate)
> > {
> > xfs_ioend_t *ioend = bh->b_private;
> > - static spinlock_t unwritten_done_lock = SPIN_LOCK_UNLOCKED;
> > + static DECLARE_SPINLOCK(unwritten_done_lock);
>
> applied, with the additional detail that it's DEFINE, not DECLARE.
Yeah, thanks .
Daniel
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2005-09-28 15:04 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-09-27 18:32 [PATCH] RT: unwritten_done_lock to DEFINE_SPINLOCK Daniel Walker
2005-09-27 22:28 ` Thomas Gleixner
2005-09-28 9:34 ` Ingo Molnar
2005-09-28 15:04 ` Daniel Walker
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox