The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Al Viro <viro@ftp.linux.org.uk>
To: Linus Torvalds <torvalds@osdl.org>
Cc: Rick Lindsley <ricklind@us.ibm.com>,
	Robert Derr <rderr@weatherflow.com>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	amitarora@in.ibm.com, suzukikp@in.ibm.com,
	Al Viro <viro@ZenIV.linux.org.uk>
Subject: Re: 2.6.13.3 Memory leak, names_cache
Date: Fri, 7 Oct 2005 00:31:37 +0100	[thread overview]
Message-ID: <20051006233137.GY7992@ftp.linux.org.uk> (raw)
In-Reply-To: <Pine.LNX.4.64.0510061428340.31407@g5.osdl.org>

On Thu, Oct 06, 2005 at 02:31:38PM -0700, Linus Torvalds wrote:
> 
> 
> On Thu, 6 Oct 2005, Rick Lindsley wrote:
> > 
> > The code in open_namei() is a bit non-intuitive in error conditions,
> > but the general fix appears to be pretty straightforward.  Let me know if
> > this patch seems to do the trick for you.
> 
> This patch seems to be correct.
> 
> As far as I can tell, the name in "last.name" has always been allocated 
> with "__getname()", and it should thus always be free'd with "__putname()" 
> in order to not cause trouble with the horrible AUDITSYSCALL code.
> 
> Now, very arguably the real bug is that bug-prone code in AUDITSYSCALL, 
> but I suspect that for 2.6.14 I should just apply this patch.
> 
> Al? Any comments? (Full patch quoted here in case you haven't followed the 
> mailing list)

ACK, and the only comment is that audit crap would be better off in /dev/null.
Too late for that now, unfortunately...

      reply	other threads:[~2005-10-06 23:31 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-10-06 18:34 2.6.13.3 Memory leak, names_cache Robert Derr
2005-10-06 19:03 ` Linus Torvalds
2005-10-06 19:24   ` Robert Derr
2005-10-06 19:54     ` Linus Torvalds
2005-10-06 20:03 ` Rick Lindsley
2005-10-06 21:17   ` Robert Derr
2005-10-06 21:31   ` Linus Torvalds
2005-10-06 23:31     ` Al Viro [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20051006233137.GY7992@ftp.linux.org.uk \
    --to=viro@ftp.linux.org.uk \
    --cc=amitarora@in.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rderr@weatherflow.com \
    --cc=ricklind@us.ibm.com \
    --cc=suzukikp@in.ibm.com \
    --cc=torvalds@osdl.org \
    --cc=viro@ZenIV.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox