The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Robert Derr <rderr@weatherflow.com>
To: Rick Lindsley <ricklind@us.ibm.com>
Cc: linux-kernel@vger.kernel.org, amitarora@in.ibm.com,
	suzukikp@in.ibm.com, torvalds@osdl.org
Subject: Re: 2.6.13.3 Memory leak, names_cache
Date: Thu, 06 Oct 2005 17:17:12 -0400	[thread overview]
Message-ID: <43459458.9080808@weatherflow.com> (raw)
In-Reply-To: <200510062003.j96K3In0016900@owlet.beaverton.ibm.com>

Rick Lindsley wrote:
> Are you running with CONFIG_AUDITSYSCALL?
>
> We ran into what sounds like the same problem and we're testing
> a patch right now for a names_cache growth which only occurs
> with CONFIG_AUDITSYSCALL enabled, and then only every time you
> traverse a symlink.  In open_namei(), in the do_link section, we call
> __do_follow_link() which will bypass the auditing whether it's enabled
> or not.  However at the end of this section, we will call putname(),
> which will *not* actually do a __putname() if auditing is enabled because
> it believes it will happen at syscall return.  So we slowly lose memory
> with each link traversal.
>
> The code in open_namei() is a bit non-intuitive in error conditions,
> but the general fix appears to be pretty straightforward.  Let me know if
> this patch seems to do the trick for you.
>
>
>   
Thanks Rick and Linus,

Rick, I put in your patch and after running for 15 minutes the system is 
holding steady at around 60-80 allocations.  Before it would have 
already have been up to a few thousand.  I'll know for sure tomorrow 
morning.

Thanks again for everyone's help,
Robert J Derr
Weatherflow, Inc.



  reply	other threads:[~2005-10-06 21:17 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-10-06 18:34 2.6.13.3 Memory leak, names_cache Robert Derr
2005-10-06 19:03 ` Linus Torvalds
2005-10-06 19:24   ` Robert Derr
2005-10-06 19:54     ` Linus Torvalds
2005-10-06 20:03 ` Rick Lindsley
2005-10-06 21:17   ` Robert Derr [this message]
2005-10-06 21:31   ` Linus Torvalds
2005-10-06 23:31     ` Al Viro

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=43459458.9080808@weatherflow.com \
    --to=rderr@weatherflow.com \
    --cc=amitarora@in.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ricklind@us.ibm.com \
    --cc=suzukikp@in.ibm.com \
    --cc=torvalds@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox