From: Greg KH <greg@kroah.com>
To: Christoph Hellwig <hch@infradead.org>,
"Kolli, Neela Syam" <Neela.Kolli@engenio.com>,
Russell King <rmk+lkml@arm.linux.org.uk>,
Linux Kernel List <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@osdl.org>,
linux-scsi@vger.kernel.org
Subject: Re: [PATCH 2/2] Convert megaraid to use pci_driver shutdown metho d
Date: Mon, 17 Oct 2005 10:17:13 -0700 [thread overview]
Message-ID: <20051017171713.GE1251@kroah.com> (raw)
In-Reply-To: <20051017171025.GA9540@infradead.org>
On Mon, Oct 17, 2005 at 06:10:25PM +0100, Christoph Hellwig wrote:
> On Mon, Oct 17, 2005 at 10:08:55AM -0700, Greg KH wrote:
> > On Mon, Oct 17, 2005 at 02:42:28PM +0100, Christoph Hellwig wrote:
> > > On Mon, Oct 17, 2005 at 09:26:12AM -0400, Kolli, Neela Syam wrote:
> > > > Patch looks good. Thanks for the patch.
> > >
> > > another 2.6.14 candidate, without it we'd easily get corruption
> > > on shutdown when the root filesystem is on megaraid.
> >
> > No, the megaraid shutdown method will be called, only if that member
> > isn't set will the pci shutdown call be made. So this should be safe
> > today, right?
>
> If that actually got fixed it's fine indeed.
The code today is:
/* FIXME, once all of the existing PCI drivers have been fixed to set
* the pci shutdown function, this test can go away. */
if (!drv->driver.shutdown)
drv->driver.shutdown = pci_device_shutdown;
so we should be fine.
thanks,
greg k-h
prev parent reply other threads:[~2005-10-17 17:17 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-10-17 13:26 [PATCH 2/2] Convert megaraid to use pci_driver shutdown metho d Kolli, Neela Syam
2005-10-17 13:42 ` Christoph Hellwig
2005-10-17 17:08 ` Greg KH
2005-10-17 17:10 ` Christoph Hellwig
2005-10-17 17:17 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051017171713.GE1251@kroah.com \
--to=greg@kroah.com \
--cc=Neela.Kolli@engenio.com \
--cc=akpm@osdl.org \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=rmk+lkml@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox