From: Christoph Hellwig <hch@infradead.org>
To: "Kolli, Neela Syam" <Neela.Kolli@engenio.com>
Cc: Russell King <rmk+lkml@arm.linux.org.uk>,
Linux Kernel List <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@osdl.org>, Greg KH <greg@kroah.com>,
linux-scsi@vger.kernel.org
Subject: Re: [PATCH 2/2] Convert megaraid to use pci_driver shutdown metho d
Date: Mon, 17 Oct 2005 14:42:28 +0100 [thread overview]
Message-ID: <20051017134228.GA31938@infradead.org> (raw)
In-Reply-To: <0E3FA95632D6D047BA649F95DAB60E5707232141@exa-atlanta>
On Mon, Oct 17, 2005 at 09:26:12AM -0400, Kolli, Neela Syam wrote:
> Patch looks good. Thanks for the patch.
another 2.6.14 candidate, without it we'd easily get corruption
on shutdown when the root filesystem is on megaraid.
> From: Russell King [mailto:rmk+lkml@arm.linux.org.uk]
> Sent: Sunday, October 16, 2005 4:33 PM
> To: Linux Kernel List; Andrew Morton; Greg KH; Neela.Kolli@engenio.com
> Subject: Re: [PATCH 2/2] Convert megaraid to use pci_driver shutdown method
>
> Convert megaraid to use pci_driver's shutdown method rather than
> the generic device_driver shutdown method.
>
> Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
>
> diff --git a/drivers/scsi/megaraid/megaraid_mbox.c
> b/drivers/scsi/megaraid/megaraid_mbox.c
> --- a/drivers/scsi/megaraid/megaraid_mbox.c
> +++ b/drivers/scsi/megaraid/megaraid_mbox.c
> @@ -76,7 +76,7 @@ static void megaraid_exit(void);
>
> static int megaraid_probe_one(struct pci_dev*, const struct pci_device_id
> *);
> static void megaraid_detach_one(struct pci_dev *);
> -static void megaraid_mbox_shutdown(struct device *);
> +static void megaraid_mbox_shutdown(struct pci_dev *);
>
> static int megaraid_io_attach(adapter_t *);
> static void megaraid_io_detach(adapter_t *);
> @@ -369,9 +369,7 @@ static struct pci_driver megaraid_pci_dr
> .id_table = pci_id_table_g,
> .probe = megaraid_probe_one,
> .remove = __devexit_p(megaraid_detach_one),
> - .driver = {
> - .shutdown = megaraid_mbox_shutdown,
> - }
> + .shutdown = megaraid_mbox_shutdown,
> };
>
>
> @@ -673,9 +671,9 @@ megaraid_detach_one(struct pci_dev *pdev
> * Shutdown notification, perform flush cache
> */
> static void
> -megaraid_mbox_shutdown(struct device *device)
> +megaraid_mbox_shutdown(struct pci_dev *pdev)
> {
> - adapter_t *adapter =
> pci_get_drvdata(to_pci_dev(device));
> + adapter_t *adapter = pci_get_drvdata(pdev);
> static int counter;
>
> if (!adapter) {
>
next prev parent reply other threads:[~2005-10-17 13:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-10-17 13:26 [PATCH 2/2] Convert megaraid to use pci_driver shutdown metho d Kolli, Neela Syam
2005-10-17 13:42 ` Christoph Hellwig [this message]
2005-10-17 17:08 ` Greg KH
2005-10-17 17:10 ` Christoph Hellwig
2005-10-17 17:17 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051017134228.GA31938@infradead.org \
--to=hch@infradead.org \
--cc=Neela.Kolli@engenio.com \
--cc=akpm@osdl.org \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=rmk+lkml@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox