public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH 4/9] ipmi: poweroff cleanups
@ 2005-10-21 14:52 Corey Minyard
  0 siblings, 0 replies; only message in thread
From: Corey Minyard @ 2005-10-21 14:52 UTC (permalink / raw)
  To: linux-kernel, akpm

Make module_param and MODULE_PARAM_DESC agree on poweroff_powercycle
name.

There was an extraneous ifdef in the IPMI poweroff code that
prevented it from working if PROC_FS was disabled.

Signed-off-by: Matt Domsch <Matt_Domsch@dell.com>
Signed-off-by: Corey Minyard <minyard@acm.org>

Index: asdf/drivers/char/ipmi/ipmi_poweroff.c
===================================================================
--- asdf.orig/drivers/char/ipmi/ipmi_poweroff.c
+++ asdf/drivers/char/ipmi/ipmi_poweroff.c
@@ -56,7 +56,7 @@ static int poweroff_powercycle;
 
 /* parameter definition to allow user to flag power cycle */
 module_param(poweroff_powercycle, int, 0644);
-MODULE_PARM_DESC(poweroff_powercycles, " Set to non-zero to enable power cycle instead of power down. Power cycle is contingent on hardware support, otherwise it defaults back to power down.");
+MODULE_PARM_DESC(poweroff_powercycle, " Set to non-zero to enable power cycle instead of power down. Power cycle is contingent on hardware support, otherwise it defaults back to power down.");
 
 /* Stuff from the get device id command. */
 static unsigned int mfg_id;
@@ -611,9 +611,7 @@ static int ipmi_poweroff_init (void)
 	}
 #endif
 
-#ifdef CONFIG_PROC_FS
 	rv = ipmi_smi_watcher_register(&smi_watcher);
-#endif
 	if (rv) {
 		unregister_sysctl_table(ipmi_table_header);
 		printk(KERN_ERR PFX "Unable to register SMI watcher: %d\n", rv);

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2005-10-21 14:52 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-10-21 14:52 [PATCH 4/9] ipmi: poweroff cleanups Corey Minyard

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox