The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Al Viro <viro@ftp.linux.org.uk>
To: Miklos Szeredi <miklos@szeredi.hu>
Cc: akpm@osdl.org, linux-kernel@vger.kernel.org,
	linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH 2/8] VFS: per inode statfs (core)
Date: Tue, 25 Oct 2005 05:25:19 +0100	[thread overview]
Message-ID: <20051025042519.GJ7992@ftp.linux.org.uk> (raw)
In-Reply-To: <E1EU5bT-0005sq-00@dorka.pomaz.szeredi.hu>

On Mon, Oct 24, 2005 at 06:55:19PM +0200, Miklos Szeredi wrote:
> This patch adds a statfs method to inode operations.  This is invoked
> whenever the dentry is available (not called from sys_ustat()) and the
> filesystem implements this method.  Otherwise the normal
> s_op->statfs() will be called.
> 
> This change is backward compatible, but calls to vfs_statfs() should
> be changed to vfs_dentry_statfs() whenever possible.

What the fuck for?  statfs() returns data that by definition should
not depend on inode within a filesystem.

NAK, and if FUSE needs that for something, it's *badly* misdesigned.

  reply	other threads:[~2005-10-25  4:25 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-10-24 16:55 [PATCH 2/8] VFS: per inode statfs (core) Miklos Szeredi
2005-10-25  4:25 ` Al Viro [this message]
2005-10-25  5:44   ` Miklos Szeredi
2005-10-26 17:31     ` Jan Hudec
2005-10-26 19:17       ` Miklos Szeredi
2005-10-26 19:52         ` Jan Hudec
2005-10-26 20:10           ` Miklos Szeredi
2005-10-26 20:15             ` Anton Altaparmakov
2005-10-27  8:07             ` Jan Hudec
2005-10-27  8:23               ` Miklos Szeredi
2005-10-27 12:35                 ` Trond Myklebust
2005-10-27 12:53                   ` Miklos Szeredi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20051025042519.GJ7992@ftp.linux.org.uk \
    --to=viro@ftp.linux.org.uk \
    --cc=akpm@osdl.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=miklos@szeredi.hu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox