Re: [PATCH 2/8] VFS: per inode statfs (core)

[Jan Hudec <bulb@ucw.cz>]

[-- Attachment #1: Type: text/plain, Size: 1112 bytes --]

On Tue, Oct 25, 2005 at 07:44:30 +0200, Miklos Szeredi wrote:
> > > This patch adds a statfs method to inode operations.  This is invoked
> > > whenever the dentry is available (not called from sys_ustat()) and the
> > > filesystem implements this method.  Otherwise the normal
> > > s_op->statfs() will be called.
> > > 
> > > This change is backward compatible, but calls to vfs_statfs() should
> > > be changed to vfs_dentry_statfs() whenever possible.
> > 
> > What the fuck for?  statfs() returns data that by definition should
> > not depend on inode within a filesystem.
> 
> Exactly.  But it's specified nowhere that there has to be a one-one
> mapping between remote filesystem - local filesystem.

Unfortunately making statfs alone aware of them does not help. Most useful
tools that use statfs go to /proc/mouts, read all the entries and invoke
statfs for each path. So if for some non-root path different values are
returned, these tools won't see them anyway. So try to think about how to
provide the info about subfilesystems first.

--
						 Jan 'Bulb' Hudec <bulb@ucw.cz>

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 189 bytes --]