From: Denis Vlasenko <vda@ilport.com.ua>
To: "Cipriani, Lawrence V (Larry)" <lvc@lucent.com>,
kai.germaschewski@gmx.de, kkeil@suse.de,
isdn4linux@listserv.isdn4linux.de
Cc: "David S. Miller" <davem@davemloft.net>, linux-kernel@vger.kernel.org
Subject: Re: bugs in /usr/src/linux/net/ipv6/mcast.c
Date: Thu, 17 Nov 2005 15:46:00 +0200 [thread overview]
Message-ID: <200511171546.00862.vda@ilport.com.ua> (raw)
In-Reply-To: <0C6AA2145B810F499C69B0947DC5078107BCDE20@oh0012exch001p.cb.lucent.com>
On 2.6.14 in drivers/isdn/hisax:
# grep -r '[^a-z0-9_]if *([^()]*([^)]*)[^)]*);' .
./hfc_sx.c: if (Read_hfc(cs, HFCSX_INT_S1));
./hfc_sx.c: if (Read_hfc(cs, HFCSX_INT_S2));
./hfc_sx.c: if (Read_hfc(cs, HFCSX_INT_S1));
./hfc_pci.c: if (Read_hfc(cs, HFCPCI_INT_S1));
./hfc_pci.c: if (Read_hfc(cs, HFCPCI_INT_S1));
./hfc_pci.c: if (Read_hfc(cs, HFCPCI_INT_S1));
These are not bugs, but rather "interesting" coding style:
Write_hfc(cs, HFCSX_INT_M1, cs->hw.hfcsx.int_m1);
/* Clear already pending ints */
if (Read_hfc(cs, HFCSX_INT_S1));
Write_hfc(cs, HFCSX_STATES, HFCSX_LOAD_STATE | 2); /* HFC ST 2 */
Obviously author tried to silence something like lint.
I think it may be replaced with (void)expr; construct.
--
vda
next prev parent reply other threads:[~2005-11-17 13:46 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-11-16 22:24 bugs in /usr/src/linux/net/ipv6/mcast.c Cipriani, Lawrence V (Larry)
2005-11-17 13:00 ` [PATCH] " Denis Vlasenko
2005-11-20 2:01 ` [linux-dvb-maintainer] " Johannes Stezenbach
2005-11-20 11:27 ` Denis Vlasenko
2005-11-21 2:19 ` Johannes Stezenbach
2005-11-17 13:46 ` Denis Vlasenko [this message]
-- strict thread matches above, loose matches on Subject: below --
2005-11-16 22:28 Cipriani, Lawrence V (Larry)
2005-11-16 14:53 Cipriani, Lawrence V (Larry)
2005-11-16 21:02 ` David S. Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200511171546.00862.vda@ilport.com.ua \
--to=vda@ilport.com.ua \
--cc=davem@davemloft.net \
--cc=isdn4linux@listserv.isdn4linux.de \
--cc=kai.germaschewski@gmx.de \
--cc=kkeil@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=lvc@lucent.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox