From: Johannes Stezenbach <js@linuxtv.org>
To: Denis Vlasenko <vda@ilport.com.ua>
Cc: "Cipriani, Lawrence V (Larry)" <lvc@lucent.com>,
Andrew Morton <akpm@osdl.org>,
kai.germaschewski@gmx.de, linux-dvb-maintainer@linuxtv.org,
"David S. Miller" <davem@davemloft.net>,
linux-kernel@vger.kernel.org
Subject: Re: [linux-dvb-maintainer] [PATCH] Re: bugs in /usr/src/linux/net/ipv6/mcast.c
Date: Mon, 21 Nov 2005 03:19:25 +0100 [thread overview]
Message-ID: <20051121021925.GC7175@linuxtv.org> (raw)
In-Reply-To: <200511201327.23475.vda@ilport.com.ua>
On Sun, Nov 20, 2005 at 01:27:23PM +0200, Denis Vlasenko wrote:
> On Sunday 20 November 2005 04:01, Johannes Stezenbach wrote:
> > Can you add your Signed-off-by: ?
>
> Sure.
>
> Signed-off-by: Denis Vlasenko <vda@ilport.com.ua>
Thanks, I added this patch to linuxtv.org CVS.
We'll see if this fix actually improves or breaks the driver ;-/
Johannes
> diff -urpN linux-2.6.14.org/drivers/media/dvb/frontends/ves1820.c linux-2.6.14.semicolon_fix/drivers/media/dvb/frontends/ves1820.c
> --- linux-2.6.14.org/drivers/media/dvb/frontends/ves1820.c Sat Nov 5 15:17:30 2005
> +++ linux-2.6.14.semicolon_fix/drivers/media/dvb/frontends/ves1820.c Thu Nov 17 14:41:05 2005
> @@ -140,25 +140,25 @@ static int ves1820_set_symbolrate(struct
> /* yeuch! */
> fpxin = state->config->xin * 10;
> fptmp = fpxin; do_div(fptmp, 123);
> - if (symbolrate < fptmp);
> + if (symbolrate < fptmp)
> SFIL = 1;
> fptmp = fpxin; do_div(fptmp, 160);
> - if (symbolrate < fptmp);
> + if (symbolrate < fptmp)
> SFIL = 0;
> fptmp = fpxin; do_div(fptmp, 246);
> - if (symbolrate < fptmp);
> + if (symbolrate < fptmp)
> SFIL = 1;
> fptmp = fpxin; do_div(fptmp, 320);
> - if (symbolrate < fptmp);
> + if (symbolrate < fptmp)
> SFIL = 0;
> fptmp = fpxin; do_div(fptmp, 492);
> - if (symbolrate < fptmp);
> + if (symbolrate < fptmp)
> SFIL = 1;
> fptmp = fpxin; do_div(fptmp, 640);
> - if (symbolrate < fptmp);
> + if (symbolrate < fptmp)
> SFIL = 0;
> fptmp = fpxin; do_div(fptmp, 984);
> - if (symbolrate < fptmp);
> + if (symbolrate < fptmp)
> SFIL = 1;
>
> fin = state->config->xin >> 4;
next prev parent reply other threads:[~2005-11-21 2:20 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-11-16 22:24 bugs in /usr/src/linux/net/ipv6/mcast.c Cipriani, Lawrence V (Larry)
2005-11-17 13:00 ` [PATCH] " Denis Vlasenko
2005-11-20 2:01 ` [linux-dvb-maintainer] " Johannes Stezenbach
2005-11-20 11:27 ` Denis Vlasenko
2005-11-21 2:19 ` Johannes Stezenbach [this message]
2005-11-17 13:46 ` Denis Vlasenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051121021925.GC7175@linuxtv.org \
--to=js@linuxtv.org \
--cc=akpm@osdl.org \
--cc=davem@davemloft.net \
--cc=kai.germaschewski@gmx.de \
--cc=linux-dvb-maintainer@linuxtv.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lvc@lucent.com \
--cc=vda@ilport.com.ua \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox