Re: swsusp intermittent failures in 2.6.15-rc3-mm1

[Pavel Machek <pavel@ucw.cz>]

Hi!

> > My Thinkpad X40 (1.25 GB, ipw2200) has had fairly reliable swsusp since
> > 2.6.13 or thereabouts, and as recently as 2.6.15-rc1-mm1 I had about 20
> > successful suspend/resume cycles.  But now that I'm running
> > 2.6.15-rc3-mm1 I'm seeing intermittent failures like this:
> 
> Thanks a lot for the report.
> 
> The problem is apparently caused by my recent patch intended to speed up
> suspend.  Could you please apply the appended debug patch, try to reproduce
> the problem and send full dmesg output back to me?
> 
> Index: linux-2.6.15-rc3-mm1/kernel/power/swsusp.c
> ===================================================================
> --- linux-2.6.15-rc3-mm1.orig/kernel/power/swsusp.c	2005-12-01 22:13:17.000000000 +0100
> +++ linux-2.6.15-rc3-mm1/kernel/power/swsusp.c	2005-12-01 22:24:56.000000000 +0100
> @@ -635,12 +635,18 @@
>  	printk("Shrinking memory...  ");
>  	do {
>  #ifdef FAST_FREE
> -		tmp = count_data_pages() + count_highmem_pages();
> +		tmp = count_data_pages();
> +		printk("Data pages: %ld\n", tmp);
> +		tmp += count_highmem_pages();

You need at least count_data_pages() + 2*count_highmem_pages() free
pages (in lowmem).

								Pavel
-- 
Thanks, Sharp!