From: Andy Isaacson <adi@hexapodia.org>
To: "Rafael J. Wysocki" <rjw@sisk.pl>
Cc: linux-kernel@vger.kernel.org, Pavel Machek <pavel@ucw.cz>
Subject: Re: swsusp intermittent failures in 2.6.15-rc3-mm1
Date: Mon, 5 Dec 2005 00:02:02 -0800 [thread overview]
Message-ID: <20051205080202.GH22168@hexapodia.org> (raw)
In-Reply-To: <200512022354.43750.rjw@sisk.pl>
On Fri, Dec 02, 2005 at 11:54:43PM +0100, Rafael J. Wysocki wrote:
> Could you please apply the appended one and see if it fixes the issue?
> It's on top of the previous one.
>
> It's been compile-tested, but I have no machine with highmem to really
> test it.
>
> --- linux-2.6.15-rc3-mm1.orig/kernel/power/snapshot.c 2005-12-02 22:02:50.000000000 +0100
> +++ linux-2.6.15-rc3-mm1/kernel/power/snapshot.c 2005-12-02 23:45:13.000000000 +0100
> @@ -37,6 +37,12 @@
> unsigned int nr_copy_pages;
>
> #ifdef CONFIG_HIGHMEM
> +struct highmem_page {
> + char *data;
> + struct page *page;
> + struct highmem_page *next;
> +};
[snip]
Yep, this seems to fix the memory allocation failures at suspend.
Thanks!
(I have another separate issue with (I think) your swsusp changes, but
I'll start a new thread for it rather than extending this one.)
-andy
prev parent reply other threads:[~2005-12-05 8:02 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-12-01 17:36 swsusp intermittent failures in 2.6.15-rc3-mm1 Andy Isaacson
2005-12-01 21:42 ` Rafael J. Wysocki
2005-12-02 0:55 ` Pavel Machek
2005-12-02 9:54 ` Rafael J. Wysocki
2005-12-02 18:13 ` Pavel Machek
2005-12-02 21:58 ` Rafael J. Wysocki
2005-12-03 0:21 ` Pavel Machek
2005-12-02 18:37 ` Andy Isaacson
2005-12-02 22:02 ` Rafael J. Wysocki
2005-12-02 22:54 ` Rafael J. Wysocki
2005-12-05 8:02 ` Andy Isaacson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051205080202.GH22168@hexapodia.org \
--to=adi@hexapodia.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=rjw@sisk.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox