Re: [patch 01/2] allow gcc4 to control inlining

[Matt Mackall <mpm@selenic.com>]

On Wed, Dec 28, 2005 at 03:34:42PM +0100, Ingo Molnar wrote:
> 
> * Matt Mackall <mpm@selenic.com> wrote:
> 
> > On Wed, Dec 28, 2005 at 12:46:53PM +0100, Ingo Molnar wrote:
> > > allow gcc4 compilers to decide what to inline and what not - instead
> > > of the kernel forcing gcc to inline all the time.
> > > 
> > > Signed-off-by: Ingo Molnar <mingo@elte.hu>
> > > Signed-off-by: Arjan van de Ven <arjan@infradead.org>
> > 
> > I'm ever so slightly wary of GCC 4's stack size logic for functions 
> > with nested scopes, but I think we'll have no trouble catching any 
> > trouble cases in 2.6.16-rc.
> > 
> > Acked-by: Matt Mackall <mpm@selenic.com>
> 
> FYI, the max function-frame size did not change, so there's no 
> outrageous frames like with gcc3, just a small shift upwards.

My point is more that I wouldn't be surprised if we found a corner
case for a particular .config. But even with GCC 3 and 4k stacks,
automatic inlining worked just fine for most configs after killing
just a few offenders.

-- 
Mathematics is the supreme nostalgia of our time.