From: Al Viro <viro@ftp.linux.org.uk>
To: Ingo Molnar <mingo@elte.hu>
Cc: lkml <linux-kernel@vger.kernel.org>,
Linus Torvalds <torvalds@osdl.org>, Andrew Morton <akpm@osdl.org>,
Arjan van de Ven <arjan@infradead.org>,
Matt Mackall <mpm@selenic.com>
Subject: Re: [patch 01/2] allow gcc4 to control inlining
Date: Wed, 28 Dec 2005 18:39:12 +0000 [thread overview]
Message-ID: <20051228183912.GF27946@ftp.linux.org.uk> (raw)
In-Reply-To: <20051228114653.GB3003@elte.hu>
On Wed, Dec 28, 2005 at 12:46:53PM +0100, Ingo Molnar wrote:
> allow gcc4 compilers to decide what to inline and what not - instead
> of the kernel forcing gcc to inline all the time.
> +#define noinline __attribute__((noinline))
> +#define __always_inline inline __attribute__((always_inline))
> #define __must_check __attribute__((warn_unused_result))
> #define __compiler_offsetof(a,b) __builtin_offsetof(a,b)
You seem to be missing the rest of the patch - namely, addition of
always_inline where it is needed now...
Note that we *do* need it in quite a few places. Anything that relies on
dead code elimination to kill a call of function that doesn't exist
would better be always inlined...
next prev parent reply other threads:[~2005-12-28 18:39 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-12-28 11:46 [patch 01/2] allow gcc4 to control inlining Ingo Molnar
2005-12-28 14:26 ` Matt Mackall
2005-12-28 14:34 ` Ingo Molnar
2005-12-28 14:36 ` Matt Mackall
2005-12-28 14:39 ` Roland Dreier
2005-12-28 14:53 ` Ingo Molnar
2005-12-28 18:39 ` Al Viro [this message]
2005-12-28 19:51 ` Arjan van de Ven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051228183912.GF27946@ftp.linux.org.uk \
--to=viro@ftp.linux.org.uk \
--cc=akpm@osdl.org \
--cc=arjan@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=mpm@selenic.com \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox