From: john stultz <johnstul@us.ibm.com>
To: akpm@osdl.org
Cc: lkml <linux-kernel@vger.kernel.org>, Ingo Molnar <mingo@elte.hu>,
George Anzinger <george@mvista.com>,
Roman Zippel <zippel@linux-m68k.org>,
Ulrich Windl <ulrich.windl@rz.uni-regensburg.de>,
Thomas Gleixner <tglx@linutronix.de>,
Steven Rostedt <rostedt@goodmis.org>,
john stultz <johnstul@us.ibm.com>
Subject: [PATCH 5/10] Time: i386 Conversion - part 1: Move timer_pit.c to i8253.c
Date: Thu, 5 Jan 2006 19:14:01 -0700 [thread overview]
Message-ID: <20060106021401.6714.11426.sendpatchset@cog.beaverton.ibm.com> (raw)
In-Reply-To: <20060106021328.6714.45831.sendpatchset@cog.beaverton.ibm.com>
This patch is just a simple cleanup for the i386 arch in
preparation of moving to the generic timeofday infrastructure. It
simply moves the PIT initialization code, locks, and other code we want
to keep from some code from timer_pit.c (which will be removed) to
i8253.c.
thanks
-john
Signed-off-by: John Stultz <johnstul@us.ibm.com>
Makefile | 2 +-
i8253.c | 32 ++++++++++++++++++++++++++++++++
time.c | 5 -----
timers/timer_pit.c | 13 -------------
4 files changed, 33 insertions(+), 19 deletions(-)
linux-2.6.15-rc5_timeofday-arch-i386-part1_B15.patch
============================================
diff --git a/arch/i386/kernel/Makefile b/arch/i386/kernel/Makefile
index f10de0f..7bc053f 100644
--- a/arch/i386/kernel/Makefile
+++ b/arch/i386/kernel/Makefile
@@ -7,7 +7,7 @@ extra-y := head.o init_task.o vmlinux.ld
obj-y := process.o semaphore.o signal.o entry.o traps.o irq.o vm86.o \
ptrace.o time.o ioport.o ldt.o setup.o i8259.o sys_i386.o \
pci-dma.o i386_ksyms.o i387.o dmi_scan.o bootflag.o \
- doublefault.o quirks.o i8237.o
+ doublefault.o quirks.o i8237.o i8253.o
obj-y += cpu/
obj-y += timers/
diff --git a/arch/i386/kernel/i8253.c b/arch/i386/kernel/i8253.c
new file mode 100644
index 0000000..29cb2eb
--- /dev/null
+++ b/arch/i386/kernel/i8253.c
@@ -0,0 +1,32 @@
+/*
+ * i8253.c 8253/PIT functions
+ *
+ */
+#include <linux/spinlock.h>
+#include <linux/jiffies.h>
+#include <linux/sysdev.h>
+#include <linux/module.h>
+#include <linux/init.h>
+
+#include <asm/smp.h>
+#include <asm/delay.h>
+#include <asm/i8253.h>
+#include <asm/io.h>
+
+#include "io_ports.h"
+
+DEFINE_SPINLOCK(i8253_lock);
+EXPORT_SYMBOL(i8253_lock);
+
+void setup_pit_timer(void)
+{
+ unsigned long flags;
+
+ spin_lock_irqsave(&i8253_lock, flags);
+ outb_p(0x34,PIT_MODE); /* binary, mode 2, LSB/MSB, ch 0 */
+ udelay(10);
+ outb_p(LATCH & 0xff , PIT_CH0); /* LSB */
+ udelay(10);
+ outb(LATCH >> 8 , PIT_CH0); /* MSB */
+ spin_unlock_irqrestore(&i8253_lock, flags);
+}
diff --git a/arch/i386/kernel/time.c b/arch/i386/kernel/time.c
index 41c5b2d..6b0d4eb 100644
--- a/arch/i386/kernel/time.c
+++ b/arch/i386/kernel/time.c
@@ -82,11 +82,6 @@ extern unsigned long wall_jiffies;
DEFINE_SPINLOCK(rtc_lock);
EXPORT_SYMBOL(rtc_lock);
-#include <asm/i8253.h>
-
-DEFINE_SPINLOCK(i8253_lock);
-EXPORT_SYMBOL(i8253_lock);
-
struct timer_opts *cur_timer __read_mostly = &timer_none;
/*
diff --git a/arch/i386/kernel/timers/timer_pit.c b/arch/i386/kernel/timers/timer_pit.c
index b9b6bd5..44cbdf9 100644
--- a/arch/i386/kernel/timers/timer_pit.c
+++ b/arch/i386/kernel/timers/timer_pit.c
@@ -162,16 +162,3 @@ struct init_timer_opts __initdata timer_
.init = init_pit,
.opts = &timer_pit,
};
-
-void setup_pit_timer(void)
-{
- unsigned long flags;
-
- spin_lock_irqsave(&i8253_lock, flags);
- outb_p(0x34,PIT_MODE); /* binary, mode 2, LSB/MSB, ch 0 */
- udelay(10);
- outb_p(LATCH & 0xff , PIT_CH0); /* LSB */
- udelay(10);
- outb(LATCH >> 8 , PIT_CH0); /* MSB */
- spin_unlock_irqrestore(&i8253_lock, flags);
-}
next prev parent reply other threads:[~2006-01-06 2:15 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-01-06 2:13 [PATCH 0/10] Time: Generic Timeofday Subsystem (v B15-mm) john stultz
2006-01-06 2:13 ` [PATCH 1/10] Time: Reduced NTP rework (part 1) john stultz
2006-01-06 2:13 ` [PATCH 2/10] Time: Reduced NTP Rework (part 2) john stultz
2006-01-06 2:13 ` [PATCH 3/10] Time: Clocksource Infrastructure john stultz
2006-01-06 2:13 ` [PATCH 4/10] Time: Generic Timekeeping Infrastructure john stultz
2006-01-06 2:14 ` john stultz [this message]
2006-01-06 2:14 ` [PATCH 6/10] Time: i386 Conversion - part 2: Rework TSC Support john stultz
2006-01-06 2:14 ` [PATCH 7/10] Time: i386 Conversion - part 3: Enable Generic Timekeeping john stultz
2006-01-06 2:14 ` [PATCH 8/10] Time: i386 Conversion - part 4: Remove Old timer_opts Code john stultz
2006-01-06 2:14 ` [PATCH 9/10] Time: i386 Conversion - part 5: ACPI PM variable renaming and config change john stultz
2006-01-06 2:14 ` [PATCH 10/10] Time: i386 Clocksource Drivers john stultz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060106021401.6714.11426.sendpatchset@cog.beaverton.ibm.com \
--to=johnstul@us.ibm.com \
--cc=akpm@osdl.org \
--cc=george@mvista.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
--cc=ulrich.windl@rz.uni-regensburg.de \
--cc=zippel@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox