From: john stultz <johnstul@us.ibm.com>
To: akpm@osdl.org
Cc: lkml <linux-kernel@vger.kernel.org>, Ingo Molnar <mingo@elte.hu>,
George Anzinger <george@mvista.com>,
Roman Zippel <zippel@linux-m68k.org>,
Ulrich Windl <ulrich.windl@rz.uni-regensburg.de>,
Thomas Gleixner <tglx@linutronix.de>,
Steven Rostedt <rostedt@goodmis.org>,
john stultz <johnstul@us.ibm.com>
Subject: [PATCH 9/10] Time: i386 Conversion - part 5: ACPI PM variable renaming and config change.
Date: Thu, 5 Jan 2006 19:14:28 -0700 [thread overview]
Message-ID: <20060106021427.6714.56739.sendpatchset@cog.beaverton.ibm.com> (raw)
In-Reply-To: <20060106021328.6714.45831.sendpatchset@cog.beaverton.ibm.com>
This cleans up some of the variable names used in the old ACPI
PM timer_opts code. Specifically, it renames pmtmr_ioport and removes
the CONFIG_X86_PM_TIMER option.
thanks
-john
Signed-off-by: John Stultz <johnstul@us.ibm.com>
arch/i386/kernel/acpi/boot.c | 22 ++++++++++------------
drivers/acpi/Kconfig | 18 ------------------
drivers/acpi/osl.c | 2 --
3 files changed, 10 insertions(+), 32 deletions(-)
linux-2.6.15-rc5_timeofday-arch-i386-part5_B15.patch
============================================
diff --git a/arch/i386/kernel/acpi/boot.c b/arch/i386/kernel/acpi/boot.c
index 2a3db1a..e3318f4 100644
--- a/arch/i386/kernel/acpi/boot.c
+++ b/arch/i386/kernel/acpi/boot.c
@@ -608,9 +608,8 @@ static int __init acpi_parse_hpet(unsign
#define acpi_parse_hpet NULL
#endif
-#ifdef CONFIG_X86_PM_TIMER
-u32 pmtmr_ioport;
-#endif
+u32 acpi_pmtmr_ioport;
+int acpi_pmtmr_buggy;
static int __init acpi_parse_fadt(unsigned long phys, unsigned long size)
{
@@ -629,7 +628,6 @@ static int __init acpi_parse_fadt(unsign
acpi_fadt.force_apic_physical_destination_mode =
fadt->force_apic_physical_destination_mode;
-#ifdef CONFIG_X86_PM_TIMER
/* detect the location of the ACPI PM Timer */
if (fadt->revision >= FADT2_REVISION_ID) {
/* FADT rev. 2 */
@@ -637,22 +635,22 @@ static int __init acpi_parse_fadt(unsign
ACPI_ADR_SPACE_SYSTEM_IO)
return 0;
- pmtmr_ioport = fadt->xpm_tmr_blk.address;
+ acpi_pmtmr_ioport = fadt->xpm_tmr_blk.address;
/*
* "X" fields are optional extensions to the original V1.0
* fields, so we must selectively expand V1.0 fields if the
* corresponding X field is zero.
*/
- if (!pmtmr_ioport)
- pmtmr_ioport = fadt->V1_pm_tmr_blk;
+ if (!acpi_pmtmr_ioport)
+ acpi_pmtmr_ioport = fadt->V1_pm_tmr_blk;
} else {
/* FADT rev. 1 */
- pmtmr_ioport = fadt->V1_pm_tmr_blk;
+ acpi_pmtmr_ioport = fadt->V1_pm_tmr_blk;
}
- if (pmtmr_ioport)
- printk(KERN_INFO PREFIX "PM-Timer IO Port: %#x\n",
- pmtmr_ioport);
-#endif
+
+ if (acpi_pmtmr_ioport)
+ printk(KERN_INFO PREFIX "PM-Timer IO Port: %#x\n", acpi_pmtmr_ioport);
+
return 0;
}
diff --git a/drivers/acpi/Kconfig b/drivers/acpi/Kconfig
index fce21c2..45e6274 100644
--- a/drivers/acpi/Kconfig
+++ b/drivers/acpi/Kconfig
@@ -287,24 +287,6 @@ config ACPI_SYSTEM
This driver will enable your system to shut down using ACPI, and
dump your ACPI DSDT table using /proc/acpi/dsdt.
-config X86_PM_TIMER
- bool "Power Management Timer Support"
- depends on X86
- depends on !X86_64
- default y
- help
- The Power Management Timer is available on all ACPI-capable,
- in most cases even if ACPI is unusable or blacklisted.
-
- This timing source is not affected by powermanagement features
- like aggressive processor idling, throttling, frequency and/or
- voltage scaling, unlike the commonly used Time Stamp Counter
- (TSC) timing source.
-
- So, if you see messages like 'Losing too many ticks!' in the
- kernel logs, and/or you are using this on a notebook which
- does not yet have an HPET, you should say "Y" here.
-
config ACPI_CONTAINER
tristate "ACPI0004,PNP0A05 and PNP0A06 Container Driver (EXPERIMENTAL)"
depends on EXPERIMENTAL
diff --git a/drivers/acpi/osl.c b/drivers/acpi/osl.c
index e3cd0b1..3f2021c 100644
--- a/drivers/acpi/osl.c
+++ b/drivers/acpi/osl.c
@@ -346,9 +346,7 @@ u64 acpi_os_get_timer(void)
/* TBD: use HPET if available */
#endif
-#ifdef CONFIG_X86_PM_TIMER
/* TBD: default to PM timer if HPET was not available */
-#endif
if (!t)
printk(KERN_ERR PREFIX "acpi_os_get_timer() TBD\n");
next prev parent reply other threads:[~2006-01-06 2:15 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-01-06 2:13 [PATCH 0/10] Time: Generic Timeofday Subsystem (v B15-mm) john stultz
2006-01-06 2:13 ` [PATCH 1/10] Time: Reduced NTP rework (part 1) john stultz
2006-01-06 2:13 ` [PATCH 2/10] Time: Reduced NTP Rework (part 2) john stultz
2006-01-06 2:13 ` [PATCH 3/10] Time: Clocksource Infrastructure john stultz
2006-01-06 2:13 ` [PATCH 4/10] Time: Generic Timekeeping Infrastructure john stultz
2006-01-06 2:14 ` [PATCH 5/10] Time: i386 Conversion - part 1: Move timer_pit.c to i8253.c john stultz
2006-01-06 2:14 ` [PATCH 6/10] Time: i386 Conversion - part 2: Rework TSC Support john stultz
2006-01-06 2:14 ` [PATCH 7/10] Time: i386 Conversion - part 3: Enable Generic Timekeeping john stultz
2006-01-06 2:14 ` [PATCH 8/10] Time: i386 Conversion - part 4: Remove Old timer_opts Code john stultz
2006-01-06 2:14 ` john stultz [this message]
2006-01-06 2:14 ` [PATCH 10/10] Time: i386 Clocksource Drivers john stultz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060106021427.6714.56739.sendpatchset@cog.beaverton.ibm.com \
--to=johnstul@us.ibm.com \
--cc=akpm@osdl.org \
--cc=george@mvista.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
--cc=ulrich.windl@rz.uni-regensburg.de \
--cc=zippel@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox