From: Ingo Molnar <mingo@elte.hu>
To: Roman Zippel <zippel@linux-m68k.org>
Cc: Thomas Gleixner <tglx@linutronix.de>,
Andrew Morton <akpm@osdl.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 02/13] hrtimer: remove useless const
Date: Mon, 13 Feb 2006 12:46:12 +0100 [thread overview]
Message-ID: <20060213114612.GA30500@elte.hu> (raw)
In-Reply-To: <Pine.LNX.4.61.0602131235180.30994@scrub.home>
* Roman Zippel <zippel@linux-m68k.org> wrote:
> On Mon, 13 Feb 2006, Thomas Gleixner wrote:
>
> > > A const for arguments which are passed by value is completely ignored by
> > > gcc. It has only an effect on local variables and even here gcc doesn't
> > > need it either to produce better code.
> >
> > NACK - gcc3 produces smaller code with the const - only gcc4 fixed that
>
> That would would be a compiler problem, these const _are_ bogus.
code size is really important for the ktime ops, so i'd keep the consts
for the time being. In any case, it's definitely not a 2.6.16 change.
> [...] and this patch doesn't break anything either.
your patch makes code larger on gcc3. Please investigate why.
Ingo
next prev parent reply other threads:[~2006-02-13 11:47 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-02-13 1:09 [PATCH 02/13] hrtimer: remove useless const Roman Zippel
2006-02-13 11:28 ` Thomas Gleixner
2006-02-13 11:38 ` Roman Zippel
2006-02-13 11:46 ` Ingo Molnar [this message]
2006-02-13 11:53 ` Andrew Morton
2006-02-13 12:18 ` Roman Zippel
2006-02-13 12:30 ` Andrew Morton
2006-02-13 12:50 ` Roman Zippel
2006-02-13 19:52 ` Andrew Morton
2006-02-13 19:59 ` Ingo Molnar
2006-02-13 20:03 ` linux-os (Dick Johnson)
2006-02-13 21:21 ` Andrew Morton
2006-02-13 21:57 ` Roman Zippel
2006-02-13 12:09 ` Roman Zippel
2006-02-13 12:26 ` Roman Zippel
2006-02-13 15:54 ` Roman Zippel
2006-02-13 20:35 ` Andrew Morton
2006-02-13 22:01 ` Roman Zippel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060213114612.GA30500@elte.hu \
--to=mingo@elte.hu \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=zippel@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox