From: Andrew Morton <akpm@osdl.org>
To: Roman Zippel <zippel@linux-m68k.org>
Cc: mingo@elte.hu, tglx@linutronix.de, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 02/13] hrtimer: remove useless const
Date: Mon, 13 Feb 2006 12:35:47 -0800 [thread overview]
Message-ID: <20060213123547.41af78c4.akpm@osdl.org> (raw)
In-Reply-To: <Pine.LNX.4.61.0602131649560.30994@scrub.home>
Roman Zippel <zippel@linux-m68k.org> wrote:
>
> Hi,
>
> On Mon, 13 Feb 2006, Ingo Molnar wrote:
>
> > your patch makes code larger on gcc3. Please investigate why.
>
> Ok, I checked with 3.3.6 and 3.4.5 and adding const to ktime_divns/
> posix_cpu_nsleep fixes the problem (actually the kernel becomes even
> smaller because posix_cpu_clock_getres is better off without const), both
> are complex and noncritical functions.
> Andrew, I'd really prefer to keep the patch and I'll send a patch to add
> the const where it's actually an improvement.
>
There's been enough churn here that it'll be counterproductive for me to
continue to munge on your patches. I'll drop the lot and will await rev
#2.
I don't think any of this was critical for 2.6.16. If there's something
which you really do think needs to be in 2.6.16 then please carefully
describe the reasons for that, and make sure that the most critical
patches are staged at the head of the series.
next prev parent reply other threads:[~2006-02-13 20:36 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-02-13 1:09 [PATCH 02/13] hrtimer: remove useless const Roman Zippel
2006-02-13 11:28 ` Thomas Gleixner
2006-02-13 11:38 ` Roman Zippel
2006-02-13 11:46 ` Ingo Molnar
2006-02-13 11:53 ` Andrew Morton
2006-02-13 12:18 ` Roman Zippel
2006-02-13 12:30 ` Andrew Morton
2006-02-13 12:50 ` Roman Zippel
2006-02-13 19:52 ` Andrew Morton
2006-02-13 19:59 ` Ingo Molnar
2006-02-13 20:03 ` linux-os (Dick Johnson)
2006-02-13 21:21 ` Andrew Morton
2006-02-13 21:57 ` Roman Zippel
2006-02-13 12:09 ` Roman Zippel
2006-02-13 12:26 ` Roman Zippel
2006-02-13 15:54 ` Roman Zippel
2006-02-13 20:35 ` Andrew Morton [this message]
2006-02-13 22:01 ` Roman Zippel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060213123547.41af78c4.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
--cc=zippel@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox