From: Andrew Morton <akpm@osdl.org>
To: Badari Pulavarty <pbadari@us.ibm.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/4] change buffer_head.b_size to size_t
Date: Wed, 1 Mar 2006 17:51:35 -0800 [thread overview]
Message-ID: <20060301175135.4cd0a74e.akpm@osdl.org> (raw)
In-Reply-To: <1141075361.10542.21.camel@dyn9047017100.beaverton.ibm.com>
Badari Pulavarty <pbadari@us.ibm.com> wrote:
>
> + size_t b_size; /* size of mapping */
> + char *b_data; /* pointer to data within the page */
>
> struct block_device *b_bdev;
> bh_end_io_t *b_end_io; /* I/O completion */
> void *b_private; /* reserved for b_end_io */
> struct list_head b_assoc_buffers; /* associated with another mapping */
> + atomic_t b_count; /* users using this buffer_head */
> };
>
> /*
> Index: linux-2.6.16-rc5/fs/buffer.c
> ===================================================================
> --- linux-2.6.16-rc5.orig/fs/buffer.c 2006-02-26 21:09:35.000000000 -0800
> +++ linux-2.6.16-rc5/fs/buffer.c 2006-02-27 08:22:37.000000000 -0800
> @@ -432,7 +432,8 @@ __find_get_block_slow(struct block_devic
> printk("__find_get_block_slow() failed. "
> "block=%llu, b_blocknr=%llu\n",
> (unsigned long long)block, (unsigned long long)bh->b_blocknr);
> - printk("b_state=0x%08lx, b_size=%u\n", bh->b_state, bh->b_size);
> + printk("b_state=0x%08lx, b_size=%lu\n", bh->b_state,
> + (unsigned long)bh->b_size);
We print size_t with `%z'. Hence the cast isn't needed.
(I'll edit the diff..)
next prev parent reply other threads:[~2006-03-02 1:49 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-02-27 21:20 [PATCH 0/4] map multiple blocks in get_block() and mpage_readpages() Badari Pulavarty
2006-02-27 21:22 ` [PATCH 1/4] change buffer_head.b_size to size_t Badari Pulavarty
2006-03-02 1:51 ` Andrew Morton [this message]
2006-03-02 1:51 ` Andrew Morton
2006-03-02 2:22 ` Nathan Scott
2006-03-02 2:56 ` Andrew Morton
2006-03-06 19:54 ` Tim Pepper
2006-02-27 21:23 ` [PATCH 2/4] pass b_size to ->get_block() Badari Pulavarty
2006-03-02 1:52 ` Andrew Morton
2006-03-03 17:17 ` Badari Pulavarty
2006-02-27 21:24 ` [PATCH 3/4] map multiple blocks for mpage_readpages() Badari Pulavarty
2006-03-02 4:45 ` Andrew Morton
2006-03-03 16:51 ` Badari Pulavarty
2006-02-27 21:24 ` [PATCH 4/4] remove ->get_blocks() support Badari Pulavarty
2006-03-02 1:52 ` [PATCH 0/4] map multiple blocks in get_block() and mpage_readpages() Andrew Morton
2006-03-03 17:05 ` Badari Pulavarty
2006-03-03 20:32 ` Andrew Morton
2006-03-03 21:54 ` Badari Pulavarty
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060301175135.4cd0a74e.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pbadari@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox