From: Andrew Morton <akpm@osdl.org>
To: Dave Peterson <dsp@llnl.gov>
Cc: alan@lxorguk.ukuu.org.uk, linux-kernel@vger.kernel.org,
bluesmoke-devel@lists.sourceforge.net
Subject: Re: [PATCH 13/15] EDAC: kobject/sysfs fixes
Date: Thu, 2 Mar 2006 18:31:53 -0800 [thread overview]
Message-ID: <20060302183153.452f93d9.akpm@osdl.org> (raw)
In-Reply-To: <200603021748.13853.dsp@llnl.gov>
Dave Peterson <dsp@llnl.gov> wrote:
>
> - After we unregister a kobject, wait for our kobject release method
> to call complete(). This causes us to wait until the kobject
> reference count reaches 0. Otherwise, a task accessing the EDAC
> sysfs interface can hold the reference count above 0 until after the
> EDAC module has been unloaded. When the reference count finally
> drops to 0, this will result in an attempt to call our release
> method inside the EDAC module after the module has already been
> unloaded.
That's not really the way to do it. If you have all the correct
module_get()s and try_module_get()s and module_put()s in all the right
places, kenrel/module.c:wait_for_zero_refcount() should do this for you.
next prev parent reply other threads:[~2006-03-03 2:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-03-03 1:48 [PATCH 13/15] EDAC: kobject/sysfs fixes Dave Peterson
2006-03-03 2:31 ` Andrew Morton [this message]
2006-03-03 2:44 ` Al Viro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060302183153.452f93d9.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=bluesmoke-devel@lists.sourceforge.net \
--cc=dsp@llnl.gov \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox