From: Jouni Malinen <jkmaline@cc.hut.fi>
To: Eugene Teo <eugene.teo@eugeneteo.net>
Cc: Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: Fix hostap_cs double kfree
Date: Tue, 14 Mar 2006 19:14:22 -0800 [thread overview]
Message-ID: <20060315031422.GD9384@jm.kir.nu> (raw)
In-Reply-To: <20060315023900.GA8179@eugeneteo.net>
On Wed, Mar 15, 2006 at 10:39:00AM +0800, Eugene Teo wrote:
> prism2_config() kfree's twice if kmalloc fails.
>
> Coverity bug #930
Thanks. I'm going through the issues related to Host AP driver in
Coverity database and send a set of patches after some testing.
> --- linux-2.6/drivers/net/wireless/hostap/hostap_cs.c~ 2006-03-15 10:05:36.000000000 +0800
> +++ linux-2.6/drivers/net/wireless/hostap/hostap_cs.c 2006-03-15 10:24:53.000000000 +0800
> @@ -585,8 +585,6 @@
> parse = kmalloc(sizeof(cisparse_t), GFP_KERNEL);
> hw_priv = kmalloc(sizeof(*hw_priv), GFP_KERNEL);
> if (parse == NULL || hw_priv == NULL) {
> - kfree(parse);
> - kfree(hw_priv);
> ret = -ENOMEM;
> goto failed;
> }
This is a valid fix..
> @@ -783,8 +781,10 @@
> cs_error(link->handle, last_fn, last_ret);
>
> failed:
> - kfree(parse);
> - kfree(hw_priv);
> + if (parse)
> + kfree(parse);
> + if (hw_priv)
> + kfree(hw_priv);
> prism2_release((u_long)link);
> return ret;
.. but this is not.
--
Jouni Malinen PGP id EFC895FA
next prev parent reply other threads:[~2006-03-15 3:17 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-03-15 2:39 Fix hostap_cs double kfree Eugene Teo
2006-03-15 3:05 ` Felipe W Damasio
2006-03-15 3:55 ` Eugene Teo
2006-03-15 3:14 ` Jouni Malinen [this message]
2006-03-15 6:44 ` Eugene Teo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060315031422.GD9384@jm.kir.nu \
--to=jkmaline@cc.hut.fi \
--cc=eugene.teo@eugeneteo.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox