From: Eugene Teo <eugene.teo@eugeneteo.net>
To: Felipe W Damasio <felipewd@terra.com.br>
Cc: Linux Kernel <linux-kernel@vger.kernel.org>, jkmaline@cc.hut.fi
Subject: Re: Fix hostap_cs double kfree
Date: Wed, 15 Mar 2006 11:55:04 +0800 [thread overview]
Message-ID: <20060315035504.GA10602@eugeneteo.net> (raw)
In-Reply-To: <44178469.3090907@terra.com.br>
<quote sender="Felipe W Damasio">
> Eugene Teo wrote:
>
> > failed:
> >- kfree(parse);
> >- kfree(hw_priv);
> >+ if (parse)
> >+ kfree(parse);
> >+ if (hw_priv)
> >+ kfree(hw_priv);
>
> I don't think those if's are needed, since the kfree code already does:
>
> void kfree(const void *objp)
> {
> if (unlikely(!objp))
> return;
> ...
> }
>
> But if you really want to use it, I suggest using if (likely
> (!<pointer>)) there to hint gcc of a possible optimization.
Ah, thanks for the tip.
Eugene
--
1024D/A6D12F80 print D51D 2633 8DAC 04DB 7265 9BB8 5883 6DAA A6D1 2F80
main(i) { putchar(182623909 >> (i-1) * 5&31|!!(i<7)<<6) && main(++i); }
next prev parent reply other threads:[~2006-03-15 4:01 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-03-15 2:39 Fix hostap_cs double kfree Eugene Teo
2006-03-15 3:05 ` Felipe W Damasio
2006-03-15 3:55 ` Eugene Teo [this message]
2006-03-15 3:14 ` Jouni Malinen
2006-03-15 6:44 ` Eugene Teo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060315035504.GA10602@eugeneteo.net \
--to=eugene.teo@eugeneteo.net \
--cc=felipewd@terra.com.br \
--cc=jkmaline@cc.hut.fi \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox