From: Eugene Teo <eugene.teo@eugeneteo.net>
To: linux-kernel@vger.kernel.org
Cc: Thomas Osterried DL9SAU <thomas@x-berg.in-berlin.de>,
Ralf Baechle DL5RB <ralf@linux-mips.org>,
Hans Alblas PE1AYX <hans@esrac.ele.tue.nl>
Subject: [PATCH] Hamradio: Fix a NULL pointer dereference in net/hamradio/mkiss.c
Date: Thu, 16 Mar 2006 14:42:11 +0800 [thread overview]
Message-ID: <20060316064211.GA22681@eugeneteo.net> (raw)
Pointer ax is dereferenced before NULL check.
Coverity bug #817
Signed-off-by: Eugene Teo <eugene.teo@eugeneteo.net>
--- linux-2.6/drivers/net/hamradio/mkiss.c~ 2006-03-15 10:05:35.000000000 +0800
+++ linux-2.6/drivers/net/hamradio/mkiss.c 2006-03-16 14:31:35.000000000 +0800
@@ -844,13 +844,16 @@ static void mkiss_close(struct tty_struc
static int mkiss_ioctl(struct tty_struct *tty, struct file *file,
unsigned int cmd, unsigned long arg)
{
- struct mkiss *ax = mkiss_get(tty);
- struct net_device *dev = ax->dev;
+ struct mkiss *ax;
+ struct net_device *dev;
unsigned int tmp, err;
/* First make sure we're connected. */
if (ax == NULL)
return -ENXIO;
+
+ ax = mkiss_get(tty);
+ dev = ax->dev;
switch (cmd) {
case SIOCGIFNAME:
--
1024D/A6D12F80 print D51D 2633 8DAC 04DB 7265 9BB8 5883 6DAA A6D1 2F80
main(i) { putchar(182623909 >> (i-1) * 5&31|!!(i<7)<<6) && main(++i); }
next reply other threads:[~2006-03-16 6:43 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-03-16 6:42 Eugene Teo [this message]
2006-03-16 7:07 ` [PATCH] Hamradio: Fix a NULL pointer dereference in net/hamradio/mkiss.c Eugene Teo
2006-03-16 8:11 ` David S. Miller
2006-03-16 8:24 ` Alexey Dobriyan
2006-03-16 8:38 ` David S. Miller
2006-03-16 10:14 ` Raj Kumar Yadav
2006-03-16 10:17 ` David S. Miller
2006-03-16 11:20 ` [PATCH] Hamradio: Fix a NULL pointer dereference in net/hamradio/mkiss.c Ralf Baechle
2006-03-16 11:27 ` Ralf Baechle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060316064211.GA22681@eugeneteo.net \
--to=eugene.teo@eugeneteo.net \
--cc=hans@esrac.ele.tue.nl \
--cc=linux-kernel@vger.kernel.org \
--cc=ralf@linux-mips.org \
--cc=thomas@x-berg.in-berlin.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox