From: Ralf Baechle <ralf@linux-mips.org>
To: Eugene Teo <eugene.teo@eugeneteo.net>
Cc: linux-kernel@vger.kernel.org,
Thomas Osterried DL9SAU <thomas@x-berg.in-berlin.de>,
Hans Alblas PE1AYX <hans@esrac.ele.tue.nl>
Subject: Re: [PATCH] Hamradio: Fix a NULL pointer dereference in net/hamradio/mkiss.c
Date: Thu, 16 Mar 2006 11:27:51 +0000 [thread overview]
Message-ID: <20060316112751.GA4431@linux-mips.org> (raw)
In-Reply-To: <20060316112045.GA4067@linux-mips.org>
On Thu, Mar 16, 2006 at 11:20:45AM +0000, Ralf Baechle wrote:
> On Thu, Mar 16, 2006 at 02:42:11PM +0800, Eugene Teo wrote:
>
> > Pointer ax is dereferenced before NULL check.
> >
> > Coverity bug #817
>
> Coverity non-bug #817. The line discipline's ioctl method can only be
> called as long as sp_get(tty) is valid. Same for mkiss.
>
> Unless I'm wrong on the "locking rules" of the tty code that is and maybe
> that unobviousness is the real reason why the patch should be applied.
Oh and the same applies to Coverity bug #816.
Ralf
prev parent reply other threads:[~2006-03-16 11:27 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-03-16 6:42 [PATCH] Hamradio: Fix a NULL pointer dereference in net/hamradio/mkiss.c Eugene Teo
2006-03-16 7:07 ` Eugene Teo
2006-03-16 8:11 ` David S. Miller
2006-03-16 8:24 ` Alexey Dobriyan
2006-03-16 8:38 ` David S. Miller
2006-03-16 10:14 ` Raj Kumar Yadav
2006-03-16 10:17 ` David S. Miller
2006-03-16 11:20 ` [PATCH] Hamradio: Fix a NULL pointer dereference in net/hamradio/mkiss.c Ralf Baechle
2006-03-16 11:27 ` Ralf Baechle [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060316112751.GA4431@linux-mips.org \
--to=ralf@linux-mips.org \
--cc=eugene.teo@eugeneteo.net \
--cc=hans@esrac.ele.tue.nl \
--cc=linux-kernel@vger.kernel.org \
--cc=thomas@x-berg.in-berlin.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox