public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH]swsusp: drain high mem pages
@ 2006-03-16  3:53 Shaohua Li
  2006-03-16  9:11 ` Pavel Machek
  0 siblings, 1 reply; 2+ messages in thread
From: Shaohua Li @ 2006-03-16  3:53 UTC (permalink / raw)
  To: lkml; +Cc: Pavel Machek, Andrew Morton

Highmem could be in pcp list as well.

Signed-off-by: Shaohua Li<shaohua.li@intel.com>
---

 linux-2.6.15-root/kernel/power/snapshot.c |    1 +
 1 files changed, 1 insertion(+)

diff -puN kernel/power/snapshot.c~drain_highmem kernel/power/snapshot.c
--- linux-2.6.15/kernel/power/snapshot.c~drain_highmem	2006-03-14 13:38:16.000000000 +0800
+++ linux-2.6.15-root/kernel/power/snapshot.c	2006-03-14 14:13:30.000000000 +0800
@@ -120,6 +120,7 @@ int save_highmem(void)
 	int res = 0;
 
 	pr_debug("swsusp: Saving Highmem\n");
+	drain_local_pages();
 	for_each_zone (zone) {
 		if (is_highmem(zone))
 			res = save_highmem_zone(zone);
_



^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH]swsusp: drain high mem pages
  2006-03-16  3:53 [PATCH]swsusp: drain high mem pages Shaohua Li
@ 2006-03-16  9:11 ` Pavel Machek
  0 siblings, 0 replies; 2+ messages in thread
From: Pavel Machek @ 2006-03-16  9:11 UTC (permalink / raw)
  To: Shaohua Li; +Cc: lkml, Andrew Morton

On Čt 16-03-06 11:53:22, Shaohua Li wrote:
> Highmem could be in pcp list as well.

This explains some strangeness I was seeing before.

OTOH it is nothing but ugly these days, so this is not urgent for 2.6.16.

ACK.
								Pavel

> Signed-off-by: Shaohua Li<shaohua.li@intel.com>
> ---
> 
>  linux-2.6.15-root/kernel/power/snapshot.c |    1 +
>  1 files changed, 1 insertion(+)
> 
> diff -puN kernel/power/snapshot.c~drain_highmem kernel/power/snapshot.c
> --- linux-2.6.15/kernel/power/snapshot.c~drain_highmem	2006-03-14 13:38:16.000000000 +0800
> +++ linux-2.6.15-root/kernel/power/snapshot.c	2006-03-14 14:13:30.000000000 +0800
> @@ -120,6 +120,7 @@ int save_highmem(void)
>  	int res = 0;
>  
>  	pr_debug("swsusp: Saving Highmem\n");
> +	drain_local_pages();
>  	for_each_zone (zone) {
>  		if (is_highmem(zone))
>  			res = save_highmem_zone(zone);
> _
> 

-- 
220: * This program is distributed in the hope that it will be useful,

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2006-03-16  9:12 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-03-16  3:53 [PATCH]swsusp: drain high mem pages Shaohua Li
2006-03-16  9:11 ` Pavel Machek

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox