public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Jean Delvare <khali@linux-fr.org>
To: "Mark M. Hoffman" <mhoffman@lightlink.com>
Cc: linux-kernel@vger.kernel.org, lm-sensors@lm-sensors.org,
	Etienne Lorrain <etienne_lorrain@yahoo.fr>
Subject: Re: [PATCH 2.6.16-rc6] i2c: require type parameter for i2c-parport and i2c-parport-light
Date: Wed, 22 Mar 2006 13:32:49 +0100	[thread overview]
Message-ID: <20060322133249.7cca1de4.khali@linux-fr.org> (raw)
In-Reply-To: <20060317035856.GB3446@jupiter.solarsys.private>

Hi Mark,

> This patch forces the user to specify what type of adapter is present when
> loading i2c-parport or i2c-parport-light.  If none is specified, the driver
> init simply fails - instead of assuming adapter type 0.
> 
> This alleviates the sometimes lengthy boot time delays which can be caused
> by accidentally building one of these into a kernel along with several i2c
> slave drivers that have lengthy probe routines (e.g. hwmon drivers).
> 
> Kconfig and documentation updated accordingly.

Good patch, thanks, I've applied it. The only change I made is:

> + * (type=5) Analog Devices evaluation boards: ADM1025, ADM103[01]

I expanded it to "ADM1025, ADM1030, ADM1031", because I think it's
important to be able to just grep chip names in the documentation files
(or source code, for that matter.)

Thanks,
-- 
Jean Delvare

  reply	other threads:[~2006-03-22 12:32 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-03-13 10:27 sis96x compiled in by error: delay of one minute at boot Etienne Lorrain
2006-03-13 11:46 ` Jean Delvare
2006-03-13 22:38   ` Etienne Lorrain
2006-03-14  9:43     ` Jean Delvare
2006-03-15  3:46       ` Mark M. Hoffman
2006-03-15  9:01         ` Jean Delvare
2006-03-16  3:59           ` Mark M. Hoffman
2006-03-16  8:46             ` Jean Delvare
2006-03-16 10:53               ` Etienne Lorrain
2006-03-17  4:20                 ` [lm-sensors] " Mark M. Hoffman
2006-03-20 23:00                   ` Etienne Lorrain
2006-03-29  3:45                     ` I2C_PCA_ISA causes boot delays (was re: sis96x compiled in by error: delay of one minute at boot) Mark M. Hoffman
2006-03-29  9:26                       ` Etienne Lorrain
2006-03-29 13:38                         ` Mark M. Hoffman
2006-03-29 14:00                       ` Ian Campbell
2006-03-17  3:56               ` [lm-sensors] sis96x compiled in by error: delay of one minute at boot Mark M. Hoffman
2006-03-17  3:58                 ` [PATCH 2.6.16-rc6] i2c: require type parameter for i2c-parport and i2c-parport-light Mark M. Hoffman
2006-03-22 12:32                   ` Jean Delvare [this message]
2006-03-15 23:03       ` [ot] VIA southbridge strangeness (was: sis96x compiled in by error: delay of one minute at boot) Jan Engelhardt
2006-03-16  8:22         ` Jean Delvare

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060322133249.7cca1de4.khali@linux-fr.org \
    --to=khali@linux-fr.org \
    --cc=etienne_lorrain@yahoo.fr \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lm-sensors@lm-sensors.org \
    --cc=mhoffman@lightlink.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox