* [patch 4/9] s390: Wrong return codes in cio_ignore_proc_init().
@ 2006-04-03 17:22 Martin Schwidefsky
0 siblings, 0 replies; only message in thread
From: Martin Schwidefsky @ 2006-04-03 17:22 UTC (permalink / raw)
To: akpm, cornelia.huck, linux-kernel
From: Cornelia Huck <cornelia.huck@de.ibm.com>
[patch 4/9] s390: Wrong return codes in cio_ignore_proc_init().
cio_ignore_proc_init() returns 1 in case of success and 0 in case
of failure. The caller tests for != 0, so better return 0 in case of
success and -ENOENT in case of failure.
Signed-off-by: Cornelia Huck <cornelia.huck@de.ibm.com>
Signed-off-by: Martin Schwidefsky <schwidefsky@de.ibm.com>
---
drivers/s390/cio/blacklist.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff -urpN linux-2.6/drivers/s390/cio/blacklist.c linux-2.6-patched/drivers/s390/cio/blacklist.c
--- linux-2.6/drivers/s390/cio/blacklist.c 2006-03-20 06:53:29.000000000 +0100
+++ linux-2.6-patched/drivers/s390/cio/blacklist.c 2006-04-03 18:46:37.000000000 +0200
@@ -414,11 +414,11 @@ cio_ignore_proc_init (void)
entry = create_proc_entry ("cio_ignore", S_IFREG | S_IRUGO | S_IWUSR,
&proc_root);
if (!entry)
- return 0;
+ return -ENOENT;
entry->proc_fops = &cio_ignore_proc_fops;
- return 1;
+ return 0;
}
__initcall (cio_ignore_proc_init);
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2006-04-03 17:22 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-04-03 17:22 [patch 4/9] s390: Wrong return codes in cio_ignore_proc_init() Martin Schwidefsky
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox