public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] panic() instead of crashing on a null pointer deref in mount_block_root()
@ 2006-05-14  0:07 Jesper Juhl
  0 siblings, 0 replies; only message in thread
From: Jesper Juhl @ 2006-05-14  0:07 UTC (permalink / raw)
  To: linux-kernel; +Cc: Andrew Morton


If __getname() fails in mount_block_root() we are dead in the water, but
a panic() seems a little nicer than crashing due to a NULL pointer deref.


Signed-off-by: Jesper Juhl <jesper.juhl@gmail.com>
---

 init/do_mounts.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletion(-)


--- linux-2.6.17-rc4-git2-orig/init/do_mounts.c	2006-05-13 21:28:53.000000000 +0200
+++ linux-2.6.17-rc4-git2/init/do_mounts.c	2006-05-14 02:05:52.000000000 +0200
@@ -286,6 +286,8 @@ void __init mount_block_root(char *name,
 	char *p;
 	char b[BDEVNAME_SIZE];
 
+	if (!fs_names)
+		panic("VFS: Failed memory allocation in mount_block_root()");
 	get_fs_names(fs_names);
 retry:
 	for (p = fs_names; *p; p += strlen(p)+1) {
@@ -425,4 +427,3 @@ out:
 	security_sb_post_mountroot();
 	mount_devfs_fs ();
 }
-





^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2006-05-14  0:07 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-05-14  0:07 [PATCH] panic() instead of crashing on a null pointer deref in mount_block_root() Jesper Juhl

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox