* [-stable PATCH] UML - fix uptime
@ 2006-06-20 22:25 Jeff Dike
2006-06-20 22:55 ` [stable] " Chris Wright
0 siblings, 1 reply; 4+ messages in thread
From: Jeff Dike @ 2006-06-20 22:25 UTC (permalink / raw)
To: stable; +Cc: linux-kernel, user-mode-linux-devel
Please consider this for 2.6.17-stable. It made -mm briefly, but missed
2.6.17. It fixes the value of uptime, which was broken by a patch late in
2.6.17-rc.
The use of unsigned instead of unsigned here broke the calculations on
negative numbers that are involved in calculating wall_to_monotonic.
Signed-off-by: Jeff Dike <jdike@addtoit.com>
Index: linux-2.6.17-mm/arch/um/kernel/time_kern.c
===================================================================
--- linux-2.6.17-mm.orig/arch/um/kernel/time_kern.c 2006-06-11 16:35:49.000000000 -0400
+++ linux-2.6.17-mm/arch/um/kernel/time_kern.c 2006-06-12 17:44:54.000000000 -0400
@@ -87,7 +87,7 @@ void timer_irq(union uml_pt_regs *regs)
void time_init_kern(void)
{
- unsigned long long nsecs;
+ long long nsecs;
nsecs = os_nsecs();
set_normalized_timespec(&wall_to_monotonic, -nsecs / BILLION,
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [stable] [-stable PATCH] UML - fix uptime
2006-06-20 22:25 [-stable PATCH] UML - fix uptime Jeff Dike
@ 2006-06-20 22:55 ` Chris Wright
2006-06-21 0:49 ` Jeff Dike
0 siblings, 1 reply; 4+ messages in thread
From: Chris Wright @ 2006-06-20 22:55 UTC (permalink / raw)
To: Jeff Dike; +Cc: stable, linux-kernel, user-mode-linux-devel
* Jeff Dike (jdike@addtoit.com) wrote:
> The use of unsigned instead of unsigned here broke the calculations on
^^^^^^^^ ^^^^^^^^
Hard to imagine how that would cause a problem ;-)
Queued for -stable, thanks.
-chris
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [stable] [-stable PATCH] UML - fix uptime
2006-06-20 22:55 ` [stable] " Chris Wright
@ 2006-06-21 0:49 ` Jeff Dike
2006-06-21 1:43 ` Chris Wright
0 siblings, 1 reply; 4+ messages in thread
From: Jeff Dike @ 2006-06-21 0:49 UTC (permalink / raw)
To: Chris Wright; +Cc: stable, linux-kernel, user-mode-linux-devel
On Tue, Jun 20, 2006 at 03:55:22PM -0700, Chris Wright wrote:
> * Jeff Dike (jdike@addtoit.com) wrote:
> > The use of unsigned instead of unsigned here broke the calculations on
> ^^^^^^^^ ^^^^^^^^
> Hard to imagine how that would cause a problem ;-)
Heh, feel free to fix.
> Queued for -stable, thanks.
Thanks.
Jeff
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [stable] [-stable PATCH] UML - fix uptime
2006-06-21 0:49 ` Jeff Dike
@ 2006-06-21 1:43 ` Chris Wright
0 siblings, 0 replies; 4+ messages in thread
From: Chris Wright @ 2006-06-21 1:43 UTC (permalink / raw)
To: Jeff Dike; +Cc: Chris Wright, stable, user-mode-linux-devel, linux-kernel
* Jeff Dike (jdike@addtoit.com) wrote:
> On Tue, Jun 20, 2006 at 03:55:22PM -0700, Chris Wright wrote:
> > * Jeff Dike (jdike@addtoit.com) wrote:
> > > The use of unsigned instead of unsigned here broke the calculations on
> > ^^^^^^^^ ^^^^^^^^
> > Hard to imagine how that would cause a problem ;-)
>
> Heh, feel free to fix.
Thanks, I did when I queued it up.
-chris
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2006-06-21 1:44 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-06-20 22:25 [-stable PATCH] UML - fix uptime Jeff Dike
2006-06-20 22:55 ` [stable] " Chris Wright
2006-06-21 0:49 ` Jeff Dike
2006-06-21 1:43 ` Chris Wright
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox