* Re: [PATCH] 64bit Resource: finally enable 64bit resource sizes [not found] <200606291801.k5TI12br003227@hera.kernel.org> @ 2006-06-29 20:42 ` Chris Wedgwood 2006-06-29 20:45 ` Dave Jones 0 siblings, 1 reply; 5+ messages in thread From: Chris Wedgwood @ 2006-06-29 20:42 UTC (permalink / raw) To: Greg KH, gregkh; +Cc: Linux Kernel Mailing List what am i missing here? > --- a/arch/i386/Kconfig > +++ b/arch/i386/Kconfig > @@ -529,6 +529,7 @@ config X86_PAE > bool > depends on HIGHMEM64G > default y > + select RESOURCES_64BIT > > # Common NUMA Features > config NUMA this isn't a similar option for x86_64, so... > diff --git a/include/linux/types.h b/include/linux/types.h > index a021e15..3f23566 100644 > --- a/include/linux/types.h > +++ b/include/linux/types.h > @@ -178,9 +178,14 @@ #endif > #ifdef __KERNEL__ > typedef unsigned __bitwise__ gfp_t; > > -typedef unsigned long resource_size_t; > +#ifdef CONFIG_RESOURCES_64BIT > +typedef u64 resource_size_t; > +#else > +typedef u32 resource_size_t; > #endif > > +#endif /* __KERNEL__ */ > + > struct ustat { > __kernel_daddr_t f_tfree; > __kernel_ino_t f_tinode; means that on x86_64 resource_size_t will ot be 32-bit when previously it was 64 ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] 64bit Resource: finally enable 64bit resource sizes 2006-06-29 20:42 ` [PATCH] 64bit Resource: finally enable 64bit resource sizes Chris Wedgwood @ 2006-06-29 20:45 ` Dave Jones 2006-06-29 20:52 ` Chris Wedgwood 0 siblings, 1 reply; 5+ messages in thread From: Dave Jones @ 2006-06-29 20:45 UTC (permalink / raw) To: Chris Wedgwood; +Cc: Greg KH, gregkh, Linux Kernel Mailing List On Thu, Jun 29, 2006 at 01:42:06PM -0700, Chris Wedgwood wrote: > what am i missing here? > > > --- a/arch/i386/Kconfig > > +++ b/arch/i386/Kconfig > > @@ -529,6 +529,7 @@ config X86_PAE > > bool > > depends on HIGHMEM64G > > default y > > + select RESOURCES_64BIT > > > > # Common NUMA Features > > config NUMA > > this isn't a similar option for x86_64, so... +config RESOURCES_64BIT + bool "64 bit Memory and IO resources (EXPERIMENTAL)" if (!64BIT && EXPERIMENTAL) + default 64BIT + help + This option allows memory and IO resources to be 64 bit. Dave -- http://www.codemonkey.org.uk ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] 64bit Resource: finally enable 64bit resource sizes 2006-06-29 20:45 ` Dave Jones @ 2006-06-29 20:52 ` Chris Wedgwood 2006-06-29 20:55 ` Dave Jones 0 siblings, 1 reply; 5+ messages in thread From: Chris Wedgwood @ 2006-06-29 20:52 UTC (permalink / raw) To: Dave Jones, Greg KH, gregkh, Linux Kernel Mailing List On Thu, Jun 29, 2006 at 04:45:27PM -0400, Dave Jones wrote: Yeah I just test and it does the right think for iamd64 > +config RESOURCES_64BIT > + bool "64 bit Memory and IO resources (EXPERIMENTAL)" if (!64BIT && EXPERIMENTAL) > + default 64BIT ^^^^^ ? is that right? ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] 64bit Resource: finally enable 64bit resource sizes 2006-06-29 20:52 ` Chris Wedgwood @ 2006-06-29 20:55 ` Dave Jones 2006-06-29 21:00 ` Chris Wedgwood 0 siblings, 1 reply; 5+ messages in thread From: Dave Jones @ 2006-06-29 20:55 UTC (permalink / raw) To: Chris Wedgwood; +Cc: Greg KH, gregkh, Linux Kernel Mailing List On Thu, Jun 29, 2006 at 01:52:13PM -0700, Chris Wedgwood wrote: > On Thu, Jun 29, 2006 at 04:45:27PM -0400, Dave Jones wrote: > > Yeah I just test and it does the right think for iamd64 > > > +config RESOURCES_64BIT > > + bool "64 bit Memory and IO resources (EXPERIMENTAL)" if (!64BIT && EXPERIMENTAL) > > + default 64BIT > ^^^^^ ? > is that right? arch/x86_64/Kconfig has .. config 64BIT def_bool y so why not ? Dave -- http://www.codemonkey.org.uk ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] 64bit Resource: finally enable 64bit resource sizes 2006-06-29 20:55 ` Dave Jones @ 2006-06-29 21:00 ` Chris Wedgwood 0 siblings, 0 replies; 5+ messages in thread From: Chris Wedgwood @ 2006-06-29 21:00 UTC (permalink / raw) To: Dave Jones, Greg KH, gregkh, Linux Kernel Mailing List On Thu, Jun 29, 2006 at 04:55:57PM -0400, Dave Jones wrote: > > > + default 64BIT > > ^^^^^ ? > > is that right? > > arch/x86_64/Kconfig has .. > > config 64BIT > def_bool y > > so why not ? sorry, i wasn't aware you could put tokens like that on the RHS but yes, it seems to work just fine, so ignore me ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2006-06-29 21:00 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <200606291801.k5TI12br003227@hera.kernel.org>
2006-06-29 20:42 ` [PATCH] 64bit Resource: finally enable 64bit resource sizes Chris Wedgwood
2006-06-29 20:45 ` Dave Jones
2006-06-29 20:52 ` Chris Wedgwood
2006-06-29 20:55 ` Dave Jones
2006-06-29 21:00 ` Chris Wedgwood
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox