[RFC][PATCH 1/9] -Wshadow: Add -Wshadow to toplevel Makefile

[RFC][PATCH 1/9] -Wshadow: Add -Wshadow to toplevel Makefile

[Jesper Juhl]

(please see the mail titled 
 "[RFC][PATCH 0/9] -Wshadow: Making the kernel build clean with -Wshadow"
 for an explanation of why I'm doing this)


Add -Wshadow to the top-level Makefile.


Signed-off-by: Jesper Juhl <jesper.juhl@gmail.com>
---

 Makefile |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

--- linux-2.6.18-rc1/Makefile.orig	2006-07-10 10:31:59.000000000 +0200
+++ linux-2.6.18-rc1/Makefile	2006-07-10 10:32:33.000000000 +0200
@@ -188,7 +188,7 @@
 
 HOSTCC       = gcc
 HOSTCXX      = g++
-HOSTCFLAGS   = -Wall -Wstrict-prototypes -O2 -fomit-frame-pointer
+HOSTCFLAGS   = -Wall -Wshadow -Wstrict-prototypes -O2 -fomit-frame-pointer
 HOSTCXXFLAGS = -O2
 
 # Decide whether to build built-in, modular, or both.
@@ -307,7 +307,7 @@
 
 CPPFLAGS        := -D__KERNEL__ $(LINUXINCLUDE)
 
-CFLAGS          := -Wall -Wundef -Wstrict-prototypes -Wno-trigraphs \
+CFLAGS          := -Wall -Wshadow -Wundef -Wstrict-prototypes -Wno-trigraphs \
                    -fno-strict-aliasing -fno-common
 # Force gcc to behave correct even for buggy distributions
 CFLAGS          += $(call cc-option, -fno-stack-protector-all \

Re: [RFC][PATCH 1/9] -Wshadow: Add -Wshadow to toplevel Makefile

[David Woodhouse]

On Mon, 2006-07-10 at 13:12 +0200, Jesper Juhl wrote:
> (please see the mail titled 
>  "[RFC][PATCH 0/9] -Wshadow: Making the kernel build clean with -Wshadow"
>  for an explanation of why I'm doing this) 

I can't. You seem to have forgotten to send your sequence of emails as a
_thread_.

-- 
dwmw2

Re: [RFC][PATCH 1/9] -Wshadow: Add -Wshadow to toplevel Makefile

[Jesper Juhl]

On 10/07/06, David Woodhouse <dwmw2@infradead.org> wrote:
> On Mon, 2006-07-10 at 13:12 +0200, Jesper Juhl wrote:
> > (please see the mail titled
> >  "[RFC][PATCH 0/9] -Wshadow: Making the kernel build clean with -Wshadow"
> >  for an explanation of why I'm doing this)
>
> I can't. You seem to have forgotten to send your sequence of emails as a
> _thread_.
>

Yeah I screwed up a bit :-(
0/9 is on LKML now though. If you want I can also forward you a copy.

-- 
Jesper Juhl <jesper.juhl@gmail.com>
Don't top-post  http://www.catb.org/~esr/jargon/html/T/top-post.html
Plain text mails only, please      http://www.expita.com/nomime.html