uml: use DEFCONFIG_LIST to avoid reading host's config

uml: use DEFCONFIG_LIST to avoid reading host's config

[Paolo 'Blaisorblade' Giarrusso]

From: Paolo 'Blaisorblade' Giarrusso <blaisorblade@yahoo.it>

This should make sure that, for UML, host's configuration files are not
considered, which avoids various pains to the user. Our dependency are such that
the obtained Kconfig will be valid and will lead to successful compilation -
however they cannot prevent an user from disabling any boot device, and if an
option is not set in the read .config (say /boot/config-XXX), with make
menuconfig ARCH=um, it is not set. This always disables UBD and all console I/O
channels, which leads to non-working UML kernels, so this bothers users -
especially now, since it will happen on almost every machine
(/boot/config-`uname -r` exists almost on every machine). It can be workarounded
with make defconfig ARCH=um, but it is non-obvious and can be avoided, so please
_do_ merge this patch.

Signed-off-by: Paolo 'Blaisorblade' Giarrusso <blaisorblade@yahoo.it>
Index: linux-2.6.git/arch/um/Kconfig
===================================================================
--- linux-2.6.git.orig/arch/um/Kconfig
+++ linux-2.6.git/arch/um/Kconfig
@@ -1,3 +1,8 @@
+config DEFCONFIG_LIST
+	string
+	option defconfig_list
+	default "arch/$ARCH/defconfig"
+
 # UML uses the generic IRQ sugsystem
 config GENERIC_HARDIRQS
 	bool
Index: linux-2.6.git/init/Kconfig
===================================================================
--- linux-2.6.git.orig/init/Kconfig
+++ linux-2.6.git/init/Kconfig
@@ -1,5 +1,6 @@
 config DEFCONFIG_LIST
 	string
+	depends on !UML
 	option defconfig_list
 	default "/lib/modules/$UNAME_RELEASE/.config"
 	default "/etc/kernel-config"

Re: uml: use DEFCONFIG_LIST to avoid reading host's config

[Jeff Dike]

On Thu, Oct 05, 2006 at 10:01:47PM +0200, Paolo 'Blaisorblade' Giarrusso wrote:
> From: Paolo 'Blaisorblade' Giarrusso <blaisorblade@yahoo.it>
> 
> This should make sure that, for UML, host's configuration files are not
> considered, which avoids various pains to the user. Our dependency are such that
> the obtained Kconfig will be valid and will lead to successful compilation -
> however they cannot prevent an user from disabling any boot device, and if an
> option is not set in the read .config (say /boot/config-XXX), with make
> menuconfig ARCH=um, it is not set. This always disables UBD and all console I/O
> channels, which leads to non-working UML kernels, so this bothers users -
> especially now, since it will happen on almost every machine
> (/boot/config-`uname -r` exists almost on every machine). It can be workarounded
> with make defconfig ARCH=um, but it is non-obvious and can be avoided, so please
> _do_ merge this patch.
> 
> Signed-off-by: Paolo 'Blaisorblade' Giarrusso <blaisorblade@yahoo.it>

Acked-by: Jeff Dike <jdike@addtoit.com>

Paolo - send this to Andrew as well so it doesn't get lost.

				Jeff

Re: uml: use DEFCONFIG_LIST to avoid reading host's config

[Blaisorblade]

On Thursday 05 October 2006 23:37, Jeff Dike wrote:
> On Thu, Oct 05, 2006 at 10:01:47PM +0200, Paolo 'Blaisorblade' Giarrusso 
wrote:
> > From: Paolo 'Blaisorblade' Giarrusso <blaisorblade@yahoo.it>
> >
> > This should make sure that, for UML, host's configuration files are not
> > considered, which avoids various pains to the user. Our dependency are
> > such that the obtained Kconfig will be valid and will lead to successful
> > compilation - however they cannot prevent an user from disabling any boot
> > device, and if an option is not set in the read .config (say
> > /boot/config-XXX), with make menuconfig ARCH=um, it is not set. This
> > always disables UBD and all console I/O channels, which leads to
> > non-working UML kernels, so this bothers users - especially now, since it
> > will happen on almost every machine
> > (/boot/config-`uname -r` exists almost on every machine). It can be
> > workarounded with make defconfig ARCH=um, but it is non-obvious and can
> > be avoided, so please _do_ merge this patch.
> >
> > Signed-off-by: Paolo 'Blaisorblade' Giarrusso <blaisorblade@yahoo.it>
>
> Acked-by: Jeff Dike <jdike@addtoit.com>
>
> Paolo - send this to Andrew as well so it doesn't get lost.
Yep, doing that separately in next batch - I'm sending to Andrew 14 patches, 
this one is still in the queue with other 10 patches, then there are the UBD 
ones (about 10 right now, will shrink the number maybe).
-- 
Inform me of my mistakes, so I can keep imitating Homer Simpson's "Doh!".
Paolo Giarrusso, aka Blaisorblade
http://www.user-mode-linux.org/~blaisorblade
Chiacchiera con i tuoi amici in tempo reale! 
 http://it.yahoo.com/mail_it/foot/*http://it.messenger.yahoo.com