public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [2.6 patch] make arch/i386/kernel/io_apic.c:irq_vector[] static
@ 2006-11-13 21:03 Adrian Bunk
  2006-11-13 21:32 ` Eric W. Biederman
  2006-11-14  6:59 ` Ingo Molnar
  0 siblings, 2 replies; 3+ messages in thread
From: Adrian Bunk @ 2006-11-13 21:03 UTC (permalink / raw)
  To: Eric W. Biederman; +Cc: mingo, linux-kernel

irq_vector[] can now become static.

Signed-off-by: Adrian Bunk <bunk@stusta.de>

--- linux-2.6.19-rc5-mm1/arch/i386/kernel/io_apic.c.old	2006-11-13 18:13:14.000000000 +0100
+++ linux-2.6.19-rc5-mm1/arch/i386/kernel/io_apic.c	2006-11-13 18:13:25.000000000 +0100
@@ -1242,7 +1242,7 @@
 }
 
 /* irq_vectors is indexed by the sum of all RTEs in all I/O APICs. */
-u8 irq_vector[NR_IRQ_VECTORS] __read_mostly = { FIRST_DEVICE_VECTOR , 0 };
+static u8 irq_vector[NR_IRQ_VECTORS] __read_mostly = { FIRST_DEVICE_VECTOR , 0 };
 
 static int __assign_irq_vector(int irq)
 {

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [2.6 patch] make arch/i386/kernel/io_apic.c:irq_vector[] static
  2006-11-13 21:03 [2.6 patch] make arch/i386/kernel/io_apic.c:irq_vector[] static Adrian Bunk
@ 2006-11-13 21:32 ` Eric W. Biederman
  2006-11-14  6:59 ` Ingo Molnar
  1 sibling, 0 replies; 3+ messages in thread
From: Eric W. Biederman @ 2006-11-13 21:32 UTC (permalink / raw)
  To: Adrian Bunk; +Cc: mingo, linux-kernel

Adrian Bunk <bunk@stusta.de> writes:

> irq_vector[] can now become static.
>
> Signed-off-by: Adrian Bunk <bunk@stusta.de>

Acked-by: Eric W. Biederman <ebiederm@xmission.com>

I made this change on x86_64 and forgot it can equally apply to i386.

> --- linux-2.6.19-rc5-mm1/arch/i386/kernel/io_apic.c.old 2006-11-13
> 18:13:14.000000000 +0100
> +++ linux-2.6.19-rc5-mm1/arch/i386/kernel/io_apic.c 2006-11-13
> 18:13:25.000000000 +0100
> @@ -1242,7 +1242,7 @@
>  }
>  
>  /* irq_vectors is indexed by the sum of all RTEs in all I/O APICs. */
> -u8 irq_vector[NR_IRQ_VECTORS] __read_mostly = { FIRST_DEVICE_VECTOR , 0 };
> +static u8 irq_vector[NR_IRQ_VECTORS] __read_mostly = { FIRST_DEVICE_VECTOR , 0
> };
>  
>  static int __assign_irq_vector(int irq)
>  {

Eric

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [2.6 patch] make arch/i386/kernel/io_apic.c:irq_vector[] static
  2006-11-13 21:03 [2.6 patch] make arch/i386/kernel/io_apic.c:irq_vector[] static Adrian Bunk
  2006-11-13 21:32 ` Eric W. Biederman
@ 2006-11-14  6:59 ` Ingo Molnar
  1 sibling, 0 replies; 3+ messages in thread
From: Ingo Molnar @ 2006-11-14  6:59 UTC (permalink / raw)
  To: Adrian Bunk; +Cc: Eric W. Biederman, linux-kernel

On Mon, 2006-11-13 at 22:03 +0100, Adrian Bunk wrote:
> irq_vector[] can now become static.
> 
> Signed-off-by: Adrian Bunk <bunk@stusta.de>

Acked-by: Ingo Molnar <mingo@redhat.com>

	Ingo


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2006-11-14  7:01 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-11-13 21:03 [2.6 patch] make arch/i386/kernel/io_apic.c:irq_vector[] static Adrian Bunk
2006-11-13 21:32 ` Eric W. Biederman
2006-11-14  6:59 ` Ingo Molnar

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox