From: Randy Dunlap <randy.dunlap@oracle.com>
To: Mariusz Kozlowski <m.kozlowski@tuxland.pl>
Cc: Stefan Richter <stefanr@s5r6.in-berlin.de>,
Luca Tettamanti <kronos.it@gmail.com>,
Ben Collins <bcollins@debian.org>, Andrew Morton <akpm@osdl.org>,
linux1394-devel@lists.sourceforge.net,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] sbp2: make 1bit bitfield unsigned
Date: Wed, 15 Nov 2006 15:09:19 -0800 [thread overview]
Message-ID: <20061115150919.330b8e9a.randy.dunlap@oracle.com> (raw)
In-Reply-To: <200611160004.24800.m.kozlowski@tuxland.pl>
On Thu, 16 Nov 2006 00:04:24 +0100 Mariusz Kozlowski wrote:
> Hello,
>
> > Luca Tettamanti wrote:
> > > A signed single-bit bitfield doesn't make much sense. Make it unsigned.
> > ...
> > Committed to linux1394-2.6.git.
>
> There is a few more. Hopefuly 'grep + my eyes' caught them all.
> The patch is against 2.6.19-rc5-mm2.
'sparse' will catch them for sure.
ISDN, dvb, alsa patches need to be sent to different maintainers...
'diffstat -p1 -w70' output would be nice.
> Signed-of-by: Mariusz Kozlowski <m.kozlowski@tuxland.pl>
>
> diff -upr linux-2.6.19-rc5-mm2-a/drivers/isdn/hisax/isdnhdlc.h linux-2.6.19-rc5-mm2-b/drivers/isdn/hisax/isdnhdlc.h
> --- linux-2.6.19-rc5-mm2-a/drivers/isdn/hisax/isdnhdlc.h 2006-11-15 11:24:19.000000000 +0100
> +++ linux-2.6.19-rc5-mm2-b/drivers/isdn/hisax/isdnhdlc.h 2006-11-15 23:54:15.000000000 +0100
> @@ -41,10 +41,10 @@ struct isdnhdlc_vars {
> unsigned char shift_reg;
> unsigned char ffvalue;
>
> - int data_received:1; // set if transferring data
> - int dchannel:1; // set if D channel (send idle instead of flags)
> - int do_adapt56:1; // set if 56K adaptation
> - int do_closing:1; // set if in closing phase (need to send CRC + flag
> + unsigned int data_received:1; // set if transferring data
> + unsigned int dchannel:1; // set if D channel (send idle instead of flags)
> + unsigned int do_adapt56:1; // set if 56K adaptation
> + unsigned int do_closing:1; // set if in closing phase (need to send CRC + flag
> };
>
>
> diff -upr linux-2.6.19-rc5-mm2-a/drivers/media/dvb/frontends/l64781.c linux-2.6.19-rc5-mm2-b/drivers/media/dvb/frontends/l64781.c
> --- linux-2.6.19-rc5-mm2-a/drivers/media/dvb/frontends/l64781.c 2006-11-08 03:24:20.000000000 +0100
> +++ linux-2.6.19-rc5-mm2-b/drivers/media/dvb/frontends/l64781.c 2006-11-15 21:35:33.000000000 +0100
> @@ -36,7 +36,7 @@ struct l64781_state {
> struct dvb_frontend frontend;
>
> /* private demodulator data */
> - int first:1;
> + unsigned int first:1;
> };
>
> #define dprintk(args...) \
> diff -upr linux-2.6.19-rc5-mm2-a/sound/arm/sa11xx-uda1341.c linux-2.6.19-rc5-mm2-b/sound/arm/sa11xx-uda1341.c
> --- linux-2.6.19-rc5-mm2-a/sound/arm/sa11xx-uda1341.c 2006-11-08 03:24:20.000000000 +0100
> +++ linux-2.6.19-rc5-mm2-b/sound/arm/sa11xx-uda1341.c 2006-11-15 21:40:16.000000000 +0100
> @@ -125,7 +125,7 @@ struct audio_stream {
> #else
> dma_regs_t *dma_regs; /* points to our DMA registers */
> #endif
> - int active:1; /* we are using this stream for transfer now */
> + unsigned int active:1; /* we are using this stream for transfer now */
> int period; /* current transfer period */
> int periods; /* current count of periods registerd in the DMA engine */
> int tx_spin; /* are we recoding - flag used to do DMA trans. for sync */
>
>
> --
---
~Randy
prev parent reply other threads:[~2006-11-15 23:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-15 18:14 [PATCH] sbp2: make 1bit bitfield unsigned Luca Tettamanti
2006-11-15 19:18 ` Stefan Richter
2006-11-15 23:04 ` Mariusz Kozlowski
2006-11-15 23:09 ` Randy Dunlap [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061115150919.330b8e9a.randy.dunlap@oracle.com \
--to=randy.dunlap@oracle.com \
--cc=akpm@osdl.org \
--cc=bcollins@debian.org \
--cc=kronos.it@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux1394-devel@lists.sourceforge.net \
--cc=m.kozlowski@tuxland.pl \
--cc=stefanr@s5r6.in-berlin.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox