The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Luca Tettamanti <kronos.it@gmail.com>
To: Ben Collins <bcollins@debian.org>,
	Stefan Richter <stefanr@s5r6.in-berlin.de>
Cc: linux1394-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org
Subject: [PATCH] sbp2: make 1bit bitfield unsigned
Date: Wed, 15 Nov 2006 19:14:15 +0100	[thread overview]
Message-ID: <20061115181415.GA26751@dreamland.darkstar.lan> (raw)

A signed single-bit bitfield doesn't make much sense. Make it unsigned.

Signed-Off-By: Luca Tettamanti <kronos.it@gmail.com>

---

 drivers/ieee1394/sbp2.h |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/ieee1394/sbp2.h b/drivers/ieee1394/sbp2.h
index abbe48e..cf416c5 100644
--- a/drivers/ieee1394/sbp2.h
+++ b/drivers/ieee1394/sbp2.h
@@ -322,7 +322,7 @@ struct scsi_id_instance_data {
 	/*
 	 * Waitqueue flag for logins, reconnects, logouts, query logins
 	 */
-	int access_complete:1;
+	unsigned int access_complete:1;
 
 	/*
 	 * Pool of command orbs, so we can have more than overlapped command per id


Luca
-- 
Quando un uomo porta dei fiori a sua moglie senza motivo, 
un motivo c'e`.

             reply	other threads:[~2006-11-15 18:14 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-11-15 18:14 Luca Tettamanti [this message]
2006-11-15 19:18 ` [PATCH] sbp2: make 1bit bitfield unsigned Stefan Richter
2006-11-15 23:04   ` Mariusz Kozlowski
2006-11-15 23:09     ` Randy Dunlap

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20061115181415.GA26751@dreamland.darkstar.lan \
    --to=kronos.it@gmail.com \
    --cc=bcollins@debian.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux1394-devel@lists.sourceforge.net \
    --cc=stefanr@s5r6.in-berlin.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox