The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Andi Kleen <ak@suse.de>
To: Andrew Morton <akpm@osdl.org>
Cc: Ingo Molnar <mingo@elte.hu>, Linus Torvalds <torvalds@osdl.org>,
	linux-kernel@vger.kernel.org
Subject: Re: [patch, -rc6] x86_64: UP build fixes
Date: Thu, 16 Nov 2006 10:22:03 +0100	[thread overview]
Message-ID: <200611161022.04022.ak@suse.de> (raw)
In-Reply-To: <20061116011733.e119eae5.akpm@osdl.org>

On Thursday 16 November 2006 10:17, Andrew Morton wrote:
> On Thu, 16 Nov 2006 10:01:01 +0100
> Andi Kleen <ak@suse.de> wrote:
> 
> > +#ifdef CONFIG_HOTPLUG_CPU
> >  	hotcpu_notifier(cpu_vsyscall_notifier, 0);
> > +#endif
> 
> this part isn't needed - the definition handles that.

Thanks. Updated patch appended.

-Andi

Fix vsyscall.c compilation on UP

Broken by earlier patch by me.

Signed-off-by: Andi Kleen <ak@suse.de>

Index: linux/arch/x86_64/kernel/vsyscall.c
===================================================================
--- linux.orig/arch/x86_64/kernel/vsyscall.c
+++ linux/arch/x86_64/kernel/vsyscall.c
@@ -274,6 +274,7 @@ static void __cpuinit cpu_vsyscall_init(
 	vsyscall_set_cpu(raw_smp_processor_id());
 }
 
+#ifdef CONFIG_HOTPLUG_CPU
 static int __cpuinit
 cpu_vsyscall_notifier(struct notifier_block *n, unsigned long action, void *arg)
 {
@@ -282,6 +283,7 @@ cpu_vsyscall_notifier(struct notifier_bl
 		smp_call_function_single(cpu, cpu_vsyscall_init, NULL, 0, 1);
 	return NOTIFY_DONE;
 }
+#endif
 
 static void __init map_vsyscall(void)
 {

  reply	other threads:[~2006-11-16  9:22 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-11-16  8:48 [patch, -rc6] x86_64: UP build fixes Ingo Molnar
2006-11-16  8:58 ` Andrew Morton
2006-11-16  9:28   ` Ingo Molnar
2006-11-16  9:45     ` Ingo Molnar
2006-11-16  9:01 ` Andi Kleen
2006-11-16  9:17   ` Andrew Morton
2006-11-16  9:22     ` Andi Kleen [this message]
2006-11-16  9:48       ` Ingo Molnar
2006-11-16 10:09         ` Andi Kleen
2006-11-16 12:29           ` Ingo Molnar
2006-11-16  9:03 ` Ingo Molnar
2006-11-16  9:32   ` [patch] hotplug CPU: clean up hotcpu_notifier() use Ingo Molnar
2006-11-16 21:59     ` Linus Torvalds
2006-11-17  3:52       ` Ingo Molnar
2006-11-17  6:02         ` Linus Torvalds
2006-11-17  7:28           ` Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200611161022.04022.ak@suse.de \
    --to=ak@suse.de \
    --cc=akpm@osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=torvalds@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox