From: Andi Kleen <ak@suse.de>
To: Ingo Molnar <mingo@elte.hu>
Cc: Andrew Morton <akpm@osdl.org>, Linus Torvalds <torvalds@osdl.org>,
linux-kernel@vger.kernel.org
Subject: Re: [patch, -rc6] x86_64: UP build fixes
Date: Thu, 16 Nov 2006 11:09:37 +0100 [thread overview]
Message-ID: <200611161109.37172.ak@suse.de> (raw)
In-Reply-To: <20061116094852.GA19305@elte.hu>
On Thursday 16 November 2006 10:48, Ingo Molnar wrote:
>
> * Andi Kleen <ak@suse.de> wrote:
>
> > On Thursday 16 November 2006 10:17, Andrew Morton wrote:
> > > On Thu, 16 Nov 2006 10:01:01 +0100
> > > Andi Kleen <ak@suse.de> wrote:
> > >
> > > > +#ifdef CONFIG_HOTPLUG_CPU
> > > > hotcpu_notifier(cpu_vsyscall_notifier, 0);
> > > > +#endif
> > >
> > > this part isn't needed - the definition handles that.
> >
> > Thanks. Updated patch appended.
>
> my hotplug-CPU cleanup patch solves this in a cleaner way: by removing
> all those #ifdefs as well.
Fine, but I suspect that late in the release it's better to go
for minimal "obvious" fixes. Later it can then be cleaned up properly.
-Andi
next prev parent reply other threads:[~2006-11-16 10:09 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-16 8:48 [patch, -rc6] x86_64: UP build fixes Ingo Molnar
2006-11-16 8:58 ` Andrew Morton
2006-11-16 9:28 ` Ingo Molnar
2006-11-16 9:45 ` Ingo Molnar
2006-11-16 9:01 ` Andi Kleen
2006-11-16 9:17 ` Andrew Morton
2006-11-16 9:22 ` Andi Kleen
2006-11-16 9:48 ` Ingo Molnar
2006-11-16 10:09 ` Andi Kleen [this message]
2006-11-16 12:29 ` Ingo Molnar
2006-11-16 9:03 ` Ingo Molnar
2006-11-16 9:32 ` [patch] hotplug CPU: clean up hotcpu_notifier() use Ingo Molnar
2006-11-16 21:59 ` Linus Torvalds
2006-11-17 3:52 ` Ingo Molnar
2006-11-17 6:02 ` Linus Torvalds
2006-11-17 7:28 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200611161109.37172.ak@suse.de \
--to=ak@suse.de \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox