* [PATCH] i386 cpufreq: cs5530A allows active idle
@ 2006-11-19 19:24 David Rientjes
2006-11-19 20:55 ` Dave Jones
0 siblings, 1 reply; 3+ messages in thread
From: David Rientjes @ 2006-11-19 19:24 UTC (permalink / raw)
To: Dave Jones; +Cc: Hiroshi Miura, Zwane Mwaikambo, linux-kernel
The cs5530A will be able to go into active idle (PWRSVE) so its PCI class
revision should be accurately stored.
Cc: Hiroshi Miura <miura@da-cha.org>
Cc: Dave Jones <davej@codemonkey.org.uk>
Cc: Zwane Mwaikambo <zwane@commfireservices.com>
Signed-off-by: David Rientjes <rientjes@cs.washington.edu>
---
arch/i386/kernel/cpu/cpufreq/gx-suspmod.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/i386/kernel/cpu/cpufreq/gx-suspmod.c b/arch/i386/kernel/cpu/cpufreq/gx-suspmod.c
index 92afa3b..0b9cc8a 100644
--- a/arch/i386/kernel/cpu/cpufreq/gx-suspmod.c
+++ b/arch/i386/kernel/cpu/cpufreq/gx-suspmod.c
@@ -473,7 +473,7 @@ static int __init cpufreq_gx_init(void)
pci_read_config_byte(params->cs55x0, PCI_MODON, &(params->on_duration));
pci_read_config_byte(params->cs55x0, PCI_MODOFF, &(params->off_duration));
pci_read_config_dword(params->cs55x0, PCI_CLASS_REVISION, &class_rev);
- params->pci_rev = class_rev && 0xff;
+ params->pci_rev = class_rev & 0xff;
if ((ret = cpufreq_register_driver(&gx_suspmod_driver))) {
kfree(params);
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] i386 cpufreq: cs5530A allows active idle
2006-11-19 19:24 [PATCH] i386 cpufreq: cs5530A allows active idle David Rientjes
@ 2006-11-19 20:55 ` Dave Jones
2006-11-20 0:54 ` Alan
0 siblings, 1 reply; 3+ messages in thread
From: Dave Jones @ 2006-11-19 20:55 UTC (permalink / raw)
To: David Rientjes; +Cc: Dave Jones, Hiroshi Miura, Zwane Mwaikambo, linux-kernel
On Sun, Nov 19, 2006 at 11:24:08AM -0800, David Rientjes wrote:
> The cs5530A will be able to go into active idle (PWRSVE) so its PCI class
> revision should be accurately stored.
Already queued in cpufreq.git for .20
Dave
--
http://www.codemonkey.org.uk
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] i386 cpufreq: cs5530A allows active idle
2006-11-19 20:55 ` Dave Jones
@ 2006-11-20 0:54 ` Alan
0 siblings, 0 replies; 3+ messages in thread
From: Alan @ 2006-11-20 0:54 UTC (permalink / raw)
To: Dave Jones
Cc: David Rientjes, Dave Jones, Hiroshi Miura, Zwane Mwaikambo,
linux-kernel
On Sun, 19 Nov 2006 15:55:03 -0500
Dave Jones <davej@redhat.com> wrote:
> On Sun, Nov 19, 2006 at 11:24:08AM -0800, David Rientjes wrote:
> > The cs5530A will be able to go into active idle (PWRSVE) so its PCI class
> > revision should be accurately stored.
>
> Already queued in cpufreq.git for .20
CS5530 doesn't currently work correctly with suspend/resume anyway - you
need to restore the various SMM setups that are lost such as the VGA SMM
trap bit.
Alan
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2006-11-20 0:48 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-11-19 19:24 [PATCH] i386 cpufreq: cs5530A allows active idle David Rientjes
2006-11-19 20:55 ` Dave Jones
2006-11-20 0:54 ` Alan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox