The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Alan <alan@lxorguk.ukuu.org.uk>
To: Andrew Morton <akpm@osdl.org>
Cc: "Conke Hu" <conke.hu@amd.com>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Add IDE mode support for SB600 SATA
Date: Thu, 23 Nov 2006 11:13:07 +0000	[thread overview]
Message-ID: <20061123111307.3b249ce9@localhost.localdomain> (raw)
In-Reply-To: <20061122182610.4d9f3d98.akpm@osdl.org>

On Wed, 22 Nov 2006 18:26:10 -0800
Andrew Morton <akpm@osdl.org> wrote:

> I doubt if it's appropriate to do all this via ifdefs.  Users don't compile
> their kernels - others compile them for the users.  We need the one kernel
> binary to support both modes.   Possible?

I'm not sure we do. What the Jmicron drivers do is

- If SATA (libata) is enabled (module or built in) then turn on AHCI
- If it is not enabled then support the chip fully in SFF mode via
drivers/ide

As the AHCI mode is fundamentally better (both with respect to standards
and to performance) this makes sense.

I think the SB600 should do the same - if support is in the
kernel/modules - then turn on AHCI mode. If not then don't. No user
options needed, no complex config questions.

Alan

  reply	other threads:[~2006-11-23 11:07 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-11-22 22:23 [PATCH] Add IDE mode support for SB600 SATA Conke Hu
2006-11-23  2:26 ` Andrew Morton
2006-11-23 11:13   ` Alan [this message]
2006-11-23  2:31 ` Andrew Morton
  -- strict thread matches above, loose matches on Subject: below --
2006-11-23  4:04 Conke Hu
2006-11-23  4:20 Conke Hu
2006-11-23  8:05 ` Arjan van de Ven
2006-11-23 11:22   ` Alan
2006-11-23 13:12     ` Arjan van de Ven
2006-11-23 11:21 ` Alan
2006-11-24  6:01 ` Tejun Heo
2006-11-24  7:05   ` Tejun Heo
2006-11-24 11:13     ` Alan
2006-11-25  1:43       ` Tejun Heo
2006-11-23  4:24 Conke Hu
2006-11-23  9:50 Conke Hu
2006-11-23 10:16 Conke Hu
2006-11-23 16:35 Luugi Marsan
2006-11-23 16:45 ` Alan
2006-11-24  5:21 Conke Hu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20061123111307.3b249ce9@localhost.localdomain \
    --to=alan@lxorguk.ukuu.org.uk \
    --cc=akpm@osdl.org \
    --cc=conke.hu@amd.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox