The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Tejun Heo <htejun@gmail.com>
To: Alan <alan@lxorguk.ukuu.org.uk>
Cc: Conke Hu <conke.hu@amd.com>,
	linux-kernel@vger.kernel.org, Andrew Morton <akpm@osdl.org>,
	Jeff Garzik <jeff@garzik.org>,
	arjan@infradead.org
Subject: Re: [PATCH] Add IDE mode support for SB600 SATA
Date: Sat, 25 Nov 2006 10:43:33 +0900	[thread overview]
Message-ID: <45679FC5.8050304@gmail.com> (raw)
In-Reply-To: <20061124111313.5ec0a599@localhost.localdomain>

Alan wrote:
>> * Unlike Jmicron's case, this doesn't affect PCI bus scan.  Actually, it 
>> does change class code but that's not as disruptive as Jmicron's case 
>> and as long as ahci ignores class code, it doesn't really matter. 
>> Driver can be chosen by changing loading order - this is both plus and 
>> minus.
> 
> The load order is basically undefined. You want AHCI so we should do
> this early. That means either putting the same gunk all over the kernel
> (drivers/ide, drivers/ata/*ati* drivers/ata/ahci) or in one place.
>  
>> * As Arjan pointed out, that unlock-modify-lock sequence should be done 
>> on resume too.  
> 
> The infrastructure for this is already handled by the pci resume quirk
> patches I sent. 

As long as resume is properly handled, no problem.

Thanks.

-- 
tejun

  reply	other threads:[~2006-11-25  1:43 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-11-23  4:20 [PATCH] Add IDE mode support for SB600 SATA Conke Hu
2006-11-23  8:05 ` Arjan van de Ven
2006-11-23 11:22   ` Alan
2006-11-23 13:12     ` Arjan van de Ven
2006-11-23 11:21 ` Alan
2006-11-24  6:01 ` Tejun Heo
2006-11-24  7:05   ` Tejun Heo
2006-11-24 11:13     ` Alan
2006-11-25  1:43       ` Tejun Heo [this message]
  -- strict thread matches above, loose matches on Subject: below --
2006-11-24  5:21 Conke Hu
2006-11-23 16:35 Luugi Marsan
2006-11-23 16:45 ` Alan
2006-11-23 10:16 Conke Hu
2006-11-23  9:50 Conke Hu
2006-11-23  4:24 Conke Hu
2006-11-23  4:04 Conke Hu
2006-11-22 22:23 Conke Hu
2006-11-23  2:26 ` Andrew Morton
2006-11-23 11:13   ` Alan
2006-11-23  2:31 ` Andrew Morton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=45679FC5.8050304@gmail.com \
    --to=htejun@gmail.com \
    --cc=akpm@osdl.org \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=arjan@infradead.org \
    --cc=conke.hu@amd.com \
    --cc=jeff@garzik.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox