Re: [PATCH] WorkStruct: Fix spi_bitbang.h

[David Brownell <david-b@pacbell.net>]

On Thursday 07 December 2006 4:44 am, David Howells wrote:
> Fix spi_bitbang.h.  It need to #include <linux/workqueue.h> before it can
> compile.
> 
> Signed-Off-By: David Howells <dhowells@redhat.com>

NAK.  Headers don't compile.  A driver including this _might_ need to
include that header; most won't.


> ---
> 
>  include/linux/spi/spi_bitbang.h |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
> 
> diff --git a/include/linux/spi/spi_bitbang.h b/include/linux/spi/spi_bitbang.h
> index 16ce178..33fa727 100644
> --- a/include/linux/spi/spi_bitbang.h
> +++ b/include/linux/spi/spi_bitbang.h
> @@ -1,6 +1,8 @@
>  #ifndef	__SPI_BITBANG_H
>  #define	__SPI_BITBANG_H
>  
> +#include <linux/workqueue.h>
> +
>  /*
>   * Mix this utility code with some glue code to get one of several types of
>   * simple SPI master driver.  Two do polled word-at-a-time I/O:
> 
>