[PATCH] WorkStruct: Fix spi_bitbang.h

[PATCH] WorkStruct: Fix spi_bitbang.h

[David Howells]

Fix spi_bitbang.h.  It need to #include <linux/workqueue.h> before it can
compile.

Signed-Off-By: David Howells <dhowells@redhat.com>
---

 include/linux/spi/spi_bitbang.h |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/include/linux/spi/spi_bitbang.h b/include/linux/spi/spi_bitbang.h
index 16ce178..33fa727 100644
--- a/include/linux/spi/spi_bitbang.h
+++ b/include/linux/spi/spi_bitbang.h
@@ -1,6 +1,8 @@
 #ifndef	__SPI_BITBANG_H
 #define	__SPI_BITBANG_H
 
+#include <linux/workqueue.h>
+
 /*
  * Mix this utility code with some glue code to get one of several types of
  * simple SPI master driver.  Two do polled word-at-a-time I/O:

Re: [PATCH] WorkStruct: Fix spi_bitbang.h

[David Brownell]

On Thursday 07 December 2006 4:44 am, David Howells wrote:
> Fix spi_bitbang.h.  It need to #include <linux/workqueue.h> before it can
> compile.
> 
> Signed-Off-By: David Howells <dhowells@redhat.com>

NAK.  Headers don't compile.  A driver including this _might_ need to
include that header; most won't.


> ---
> 
>  include/linux/spi/spi_bitbang.h |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
> 
> diff --git a/include/linux/spi/spi_bitbang.h b/include/linux/spi/spi_bitbang.h
> index 16ce178..33fa727 100644
> --- a/include/linux/spi/spi_bitbang.h
> +++ b/include/linux/spi/spi_bitbang.h
> @@ -1,6 +1,8 @@
>  #ifndef	__SPI_BITBANG_H
>  #define	__SPI_BITBANG_H
>  
> +#include <linux/workqueue.h>
> +
>  /*
>   * Mix this utility code with some glue code to get one of several types of
>   * simple SPI master driver.  Two do polled word-at-a-time I/O:
> 
>

Re: [PATCH] WorkStruct: Fix spi_bitbang.h

[David Howells]

David Brownell <david-b@pacbell.net> wrote:

> NAK.  Headers don't compile.  A driver including this _might_ need to
> include that header; most won't.

Please be more specific.  It compiles for myself and for Ben.  I used the
s3c2410_defconfig configuration.  It won't compile without it.

David

Re: [PATCH] WorkStruct: Fix spi_bitbang.h

[Andrew Morton]

On Thu, 07 Dec 2006 15:37:35 +0000
David Howells <dhowells@redhat.com> wrote:

> David Brownell <david-b@pacbell.net> wrote:
> 
> > NAK.  Headers don't compile.  A driver including this _might_ need to
> > include that header; most won't.
> 
> Please be more specific.  It compiles for myself and for Ben.  I used the
> s3c2410_defconfig configuration.  It won't compile without it.
> 

It's a simple matter to quote the gcc stderr in the patch's changelog and
it is often very useful.

Re: [PATCH] WorkStruct: Fix spi_bitbang.h

[David Brownell]

On Thursday 07 December 2006 7:37 am, David Howells wrote:
> David Brownell <david-b@pacbell.net> wrote:
> 
> > NAK.  Headers don't compile.  A driver including this _might_ need to
> > include that header; most won't.
> 
> Please be more specific.  It compiles for myself and for Ben.  I used the
> s3c2410_defconfig configuration.  It won't compile without it.

So tell me, what part of the kernel build tries to compile a header
file all by itself?  What object file does it become?  And where is
that object module installed?

Now, if you have an example of some _C_ file that's needs some help
compiling, that would be interesting ... and indicative of the right
place to change.