From: Andrew Morton <akpm@osdl.org>
To: Paul Jackson <pj@sgi.com>
Cc: linux-kernel@vger.kernel.org, davej@codemonkey.org.uk,
"Myaskouvskey, Artiom" <artiom.myaskouvskey@intel.com>,
Randy Dunlap <randy.dunlap@oracle.com>,
shai.satt@intel.com, Andi Kleen <ak@suse.de>,
hpa@zytor.com
Subject: Re: [PATCH] efi is_memory_available ia64 hack build fix
Date: Fri, 8 Dec 2006 02:53:12 -0800 [thread overview]
Message-ID: <20061208025312.70a72d4c.akpm@osdl.org> (raw)
In-Reply-To: <20061208103336.4644.96389.sendpatchset@jackhammer.engr.sgi.com>
On Fri, 08 Dec 2006 02:33:36 -0800
Paul Jackson <pj@sgi.com> wrote:
> The addition of an is_available_memory() routine to some arch i386
> code, along with an extern for it in efi.h, caused the ia64 build
> to fail, which has the apparently identical routine, marked 'static'.
>
> The ia64 build fails with:
>
> arch/ia64/kernel/efi.c:229: error: static declaration of 'is_available_memory' follows non-static declaration
> include/linux/efi.h:305: error: previous declaration of 'is_available_memory' was here
That already got named to is_memory_available()
(Which I suspect is the wrong fix, because the function serves the same
purpose on ia64 as it does on x86[_64], but nobody listens to me)
next prev parent reply other threads:[~2006-12-08 10:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-08 10:33 [PATCH] efi is_memory_available ia64 hack build fix Paul Jackson
2006-12-08 10:53 ` Andrew Morton [this message]
2006-12-08 10:57 ` Paul Jackson
2006-12-08 19:12 ` Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061208025312.70a72d4c.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=ak@suse.de \
--cc=artiom.myaskouvskey@intel.com \
--cc=davej@codemonkey.org.uk \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pj@sgi.com \
--cc=randy.dunlap@oracle.com \
--cc=shai.satt@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox