From: Randy Dunlap <randy.dunlap@oracle.com>
To: Andrew Morton <akpm@osdl.org>
Cc: Paul Jackson <pj@sgi.com>,
linux-kernel@vger.kernel.org, davej@codemonkey.org.uk,
"Myaskouvskey, Artiom" <artiom.myaskouvskey@intel.com>,
shai.satt@intel.com, Andi Kleen <ak@suse.de>,
hpa@zytor.com
Subject: Re: [PATCH] efi is_memory_available ia64 hack build fix
Date: Fri, 8 Dec 2006 11:12:03 -0800 [thread overview]
Message-ID: <20061208111203.7bf56b97.randy.dunlap@oracle.com> (raw)
In-Reply-To: <20061208025312.70a72d4c.akpm@osdl.org>
On Fri, 8 Dec 2006 02:53:12 -0800 Andrew Morton wrote:
> On Fri, 08 Dec 2006 02:33:36 -0800
> Paul Jackson <pj@sgi.com> wrote:
>
> > The addition of an is_available_memory() routine to some arch i386
> > code, along with an extern for it in efi.h, caused the ia64 build
> > to fail, which has the apparently identical routine, marked 'static'.
> >
> > The ia64 build fails with:
> >
> > arch/ia64/kernel/efi.c:229: error: static declaration of 'is_available_memory' follows non-static declaration
> > include/linux/efi.h:305: error: previous declaration of 'is_available_memory' was here
>
> That already got named to is_memory_available()
>
> (Which I suspect is the wrong fix, because the function serves the same
> purpose on ia64 as it does on x86[_64], but nobody listens to me)
Paul's patch looks better to me than renaming one of them.
And the predicate name on ia64 now seems confusing, at least to me.
And EFI for x86_64 is being worked on, so it will either
use arch/i386/kernel/efi.c or duplicate lots of it.
Summary: There needs to be a place to share this and possibly other
common functions.
---
~Randy
prev parent reply other threads:[~2006-12-08 19:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-08 10:33 [PATCH] efi is_memory_available ia64 hack build fix Paul Jackson
2006-12-08 10:53 ` Andrew Morton
2006-12-08 10:57 ` Paul Jackson
2006-12-08 19:12 ` Randy Dunlap [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061208111203.7bf56b97.randy.dunlap@oracle.com \
--to=randy.dunlap@oracle.com \
--cc=ak@suse.de \
--cc=akpm@osdl.org \
--cc=artiom.myaskouvskey@intel.com \
--cc=davej@codemonkey.org.uk \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pj@sgi.com \
--cc=shai.satt@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox