public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Alan <alan@lxorguk.ukuu.org.uk>
To: Ben Collins <ben.collins@ubuntu.com>
Cc: Ralf Baechle <ralf@linux-mips.org>, Andrew Morton <akpm@osdl.org>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] PCI legacy resource fix
Date: Sat, 9 Dec 2006 02:46:27 +0000	[thread overview]
Message-ID: <20061209024627.6bb11a58@localhost.localdomain> (raw)
In-Reply-To: <1165630410.7443.346.camel@gullible>

> Checking the patch, my problem is that the old way, all BAR's were being
> set at start = end = flags = 0. The patch makes it set all the BAR's to

Yes the old quirk used to blank the resources as the values on the chip
are undefined and random. This gives you corrupt resource trees and needs
hacks in the drivers as well

> the normal values. This is what it looks like in lspci, pre this patch:
> 
>         Region 0: I/O ports at <unassigned>
>         Region 1: I/O ports at <unassigned>
>         Region 2: I/O ports at <unassigned>
>         Region 3: I/O ports at <unassigned>

Then your device is in legacy mode, or was disabled
 
> So my device is not running in compatibility mode, and should not have

The paste you have their shows that it almost certainly is in legacy mode.

> the BAR's set, as Alan's patch does.

Dump the class code and other bits during boot check how your device is
seen (native v legacy/compatibility) and whether the fixup logic
triggers. It should only trigger for legacy devices.

Alan

  reply	other threads:[~2006-12-09  2:38 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-12-06 13:41 [PATCH] PCI legacy resource fix Ralf Baechle
2006-12-06 13:57 ` Alan
2006-12-09  0:46 ` Ben Collins
2006-12-09  1:25   ` Ralf Baechle
2006-12-09  2:13     ` Ben Collins
2006-12-09  2:46       ` Alan [this message]
2006-12-09  8:12         ` Ben Collins
2006-12-09 13:14           ` Alan
2006-12-09 15:50             ` Ben Collins
2006-12-09 13:15           ` Alan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20061209024627.6bb11a58@localhost.localdomain \
    --to=alan@lxorguk.ukuu.org.uk \
    --cc=akpm@osdl.org \
    --cc=ben.collins@ubuntu.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ralf@linux-mips.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox