From: Alan <alan@lxorguk.ukuu.org.uk>
To: Ben Collins <ben.collins@ubuntu.com>
Cc: Ralf Baechle <ralf@linux-mips.org>, Andrew Morton <akpm@osdl.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] PCI legacy resource fix
Date: Sat, 9 Dec 2006 13:14:48 +0000 [thread overview]
Message-ID: <20061209131448.4c878b64@localhost.localdomain> (raw)
In-Reply-To: <1165651931.7443.377.camel@gullible>
On Sat, 09 Dec 2006 03:12:11 -0500
Ben Collins <ben.collins@ubuntu.com> wrote:
> My controller is in legacy mode, however, it never gets to here because
> of this call, just before this block of code:
>
> rc = pci_request_regions(pdev, DRV_NAME);
> if (rc) {
> disable_dev_on_err = 0;
> goto err_out;
> }
Then you don't have the fix applied that was posted. That code is not
present in the form you pasted in the fixed version of the libata code.
It is within an if (!legacy_mode)
Alan
next prev parent reply other threads:[~2006-12-09 13:07 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-06 13:41 [PATCH] PCI legacy resource fix Ralf Baechle
2006-12-06 13:57 ` Alan
2006-12-09 0:46 ` Ben Collins
2006-12-09 1:25 ` Ralf Baechle
2006-12-09 2:13 ` Ben Collins
2006-12-09 2:46 ` Alan
2006-12-09 8:12 ` Ben Collins
2006-12-09 13:14 ` Alan [this message]
2006-12-09 15:50 ` Ben Collins
2006-12-09 13:15 ` Alan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061209131448.4c878b64@localhost.localdomain \
--to=alan@lxorguk.ukuu.org.uk \
--cc=akpm@osdl.org \
--cc=ben.collins@ubuntu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox