* [patch] rcu: rcutorture suspend fix
@ 2006-12-22 0:08 Ingo Molnar
2006-12-22 2:25 ` Paul E. McKenney
0 siblings, 1 reply; 2+ messages in thread
From: Ingo Molnar @ 2006-12-22 0:08 UTC (permalink / raw)
To: Linus Torvalds; +Cc: Paul E. McKenney, Andrew Morton, linux-kernel
Subject: [patch] rcu: rcutorture suspend fix
From: Ingo Molnar <mingo@elte.hu>
fix suspend hang: rcutorture threads need to be nofreeze.
Signed-off-by: Ingo Molnar <mingo@elte.hu>
---
kernel/rcutorture.c | 3 +++
1 file changed, 3 insertions(+)
Index: linux/kernel/rcutorture.c
===================================================================
--- linux.orig/kernel/rcutorture.c
+++ linux/kernel/rcutorture.c
@@ -522,6 +522,7 @@ rcu_torture_writer(void *arg)
VERBOSE_PRINTK_STRING("rcu_torture_writer task started");
set_user_nice(current, 19);
+ current->flags |= PF_NOFREEZE;
do {
schedule_timeout_uninterruptible(1);
@@ -561,6 +562,7 @@ rcu_torture_fakewriter(void *arg)
VERBOSE_PRINTK_STRING("rcu_torture_fakewriter task started");
set_user_nice(current, 19);
+ current->flags |= PF_NOFREEZE;
do {
schedule_timeout_uninterruptible(1 + rcu_random(&rand)%10);
@@ -591,6 +593,7 @@ rcu_torture_reader(void *arg)
VERBOSE_PRINTK_STRING("rcu_torture_reader task started");
set_user_nice(current, 19);
+ current->flags |= PF_NOFREEZE;
do {
idx = cur_ops->readlock();
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [patch] rcu: rcutorture suspend fix
2006-12-22 0:08 [patch] rcu: rcutorture suspend fix Ingo Molnar
@ 2006-12-22 2:25 ` Paul E. McKenney
0 siblings, 0 replies; 2+ messages in thread
From: Paul E. McKenney @ 2006-12-22 2:25 UTC (permalink / raw)
To: Ingo Molnar; +Cc: Linus Torvalds, Paul E. McKenney, Andrew Morton, linux-kernel
On Fri, Dec 22, 2006 at 01:08:13AM +0100, Ingo Molnar wrote:
> Subject: [patch] rcu: rcutorture suspend fix
> From: Ingo Molnar <mingo@elte.hu>
>
> fix suspend hang: rcutorture threads need to be nofreeze.
Looks straightforward enough -- I take it that rcutorture continues
upon resume? So I have to ask... Would it make sense to simply unload
the rcutorture module upon suspend?
But either way this is an improvement, so...
Acked-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
> Signed-off-by: Ingo Molnar <mingo@elte.hu>
> ---
> kernel/rcutorture.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> Index: linux/kernel/rcutorture.c
> ===================================================================
> --- linux.orig/kernel/rcutorture.c
> +++ linux/kernel/rcutorture.c
> @@ -522,6 +522,7 @@ rcu_torture_writer(void *arg)
>
> VERBOSE_PRINTK_STRING("rcu_torture_writer task started");
> set_user_nice(current, 19);
> + current->flags |= PF_NOFREEZE;
>
> do {
> schedule_timeout_uninterruptible(1);
> @@ -561,6 +562,7 @@ rcu_torture_fakewriter(void *arg)
>
> VERBOSE_PRINTK_STRING("rcu_torture_fakewriter task started");
> set_user_nice(current, 19);
> + current->flags |= PF_NOFREEZE;
>
> do {
> schedule_timeout_uninterruptible(1 + rcu_random(&rand)%10);
> @@ -591,6 +593,7 @@ rcu_torture_reader(void *arg)
>
> VERBOSE_PRINTK_STRING("rcu_torture_reader task started");
> set_user_nice(current, 19);
> + current->flags |= PF_NOFREEZE;
>
> do {
> idx = cur_ops->readlock();
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2006-12-22 2:25 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-12-22 0:08 [patch] rcu: rcutorture suspend fix Ingo Molnar
2006-12-22 2:25 ` Paul E. McKenney
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox