From: Jean Delvare <khali@linux-fr.org>
To: Thomas Meyer <thomas@m3y3r.de>,
Linus Torvalds <torvalds@osdl.org>,
Steve French <sfrench@samba.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: WARNING: "test_clear_page_dirty" [fs/cifs/cifs.ko] undefined!
Date: Fri, 22 Dec 2006 22:30:34 +0100 [thread overview]
Message-ID: <20061222223034.b29aeb5f.khali@linux-fr.org> (raw)
In-Reply-To: <458BEB9D.8030709@m3y3r.de>
On Fri, 22 Dec 2006 15:28:45 +0100, Thomas Meyer wrote:
> Again current git head:
>
> I guess this should be fixed by someone!
>
> WARNING: "test_clear_page_dirty" [fs/cifs/cifs.ko] undefined!
> make[1]: *** [__modpost] Fehler 1
> make: *** [modules] Fehler 2
This is caused by this commit:
http://www.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=fba2591bf4e418b6c3f9f8794c9dd8fe40ae7bd9
>From the log message:
"Some filesystems need to be fixed up for this: CIFS, FUSE, JFS,
ReiserFS, XFS all use the old confusing functions, and will be fixed
separately in subsequent commits (with some of them just removing the
offending logic, and others using clear_page_dirty_for_io())."
The approach seems quite broken to me, the users should have been fixed
_before_ removing the function, so as to avoid compilation failures.
These are a pain for testers, and break git bisect too. Grmbl.
Now that it's done... Steve, can you please take a look and provide a
patch so that cifs builds again?
Thanks,
--
Jean Delvare
next prev parent reply other threads:[~2006-12-22 21:30 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-22 14:28 WARNING: "test_clear_page_dirty" [fs/cifs/cifs.ko] undefined! Thomas Meyer
2006-12-22 21:30 ` Jean Delvare [this message]
2006-12-23 0:25 ` Linus Torvalds
2006-12-23 18:30 ` Linus Torvalds
2006-12-23 19:44 ` Randy Dunlap
2006-12-23 20:06 ` Linus Torvalds
2006-12-24 5:35 ` Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061222223034.b29aeb5f.khali@linux-fr.org \
--to=khali@linux-fr.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sfrench@samba.org \
--cc=thomas@m3y3r.de \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox