From: Randy Dunlap <randy.dunlap@oracle.com>
To: Linus Torvalds <torvalds@osdl.org>
Cc: Jean Delvare <khali@linux-fr.org>,
Ian McDonald <ian.mcdonald@jandi.co.nz>,
Thomas Meyer <thomas@m3y3r.de>,
linux-cifs-client@lists.samba.org,
Steve French <sfrench@samba.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@osdl.org>
Subject: Re: WARNING: "test_clear_page_dirty" [fs/cifs/cifs.ko] undefined!
Date: Sat, 23 Dec 2006 21:35:47 -0800 [thread overview]
Message-ID: <20061223213547.a0ff6425.randy.dunlap@oracle.com> (raw)
In-Reply-To: <Pine.LNX.4.64.0612231152360.3671@woody.osdl.org>
On Sat, 23 Dec 2006 12:06:43 -0800 (PST) Linus Torvalds wrote:
>
>
> On Sat, 23 Dec 2006, Randy Dunlap wrote:
> >
> > BTW, reiserfs has similar build problems: it uses clear_page_dirty()
> > so it won't build.
>
> Not any more. I fixed that one (very different issue, btw: it's not
> actually doign writeout, it actually wanted to cancel IO on truncated
> buffers.
>
> However, it's certainly possible that my fix hasn't mirrored out yet, I
> pushed it just a couple of hours ago. So if you want to test it, here are
> the two commits in question..
>
> (The "cancel_dirty_page()" cleanup is needed not just to do reiserfs as a
> module, it's also to make it more robust against reiserfs possibly feeding
> that function with strange pages, and to match the other related functions
> in the accounting functions).
>
> Len Brown tested the reiserfs changes, and claims that it was all good,
> but if somebody wants to run fsx-linux or some other filesystem stress
> testing tool that actually tests shared mmap (and truncate), that would be
> really appreciated.
I ran fsx-linux on it for one hour... with no problems reported.
---
~Randy
prev parent reply other threads:[~2006-12-24 5:35 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-22 14:28 WARNING: "test_clear_page_dirty" [fs/cifs/cifs.ko] undefined! Thomas Meyer
2006-12-22 21:30 ` Jean Delvare
2006-12-23 0:25 ` Linus Torvalds
2006-12-23 18:30 ` Linus Torvalds
2006-12-23 19:44 ` Randy Dunlap
2006-12-23 20:06 ` Linus Torvalds
2006-12-24 5:35 ` Randy Dunlap [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061223213547.a0ff6425.randy.dunlap@oracle.com \
--to=randy.dunlap@oracle.com \
--cc=akpm@osdl.org \
--cc=ian.mcdonald@jandi.co.nz \
--cc=khali@linux-fr.org \
--cc=linux-cifs-client@lists.samba.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sfrench@samba.org \
--cc=thomas@m3y3r.de \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox